Fix Coverity warning CID 1413323 (#3764)

clementFoyer · bosilca · commit c885ee3f3c7a · 2017-06-27T12:39:31.000+02:00
Signed-off-by: Clement Foyer &lt;clement.foyer@inria.fr&gt;
diff --git a/ompi/mca/common/monitoring/common_monitoring_coll.c b/ompi/mca/common/monitoring/common_monitoring_coll.c
@@ -47,7 +47,7 @@ static opal_hash_table_t *comm_data = NULL;
 static inline void mca_common_monitoring_coll_check_name(mca_monitoring_coll_data_t*data)
 {
     if( data->comm_name && data->p_comm && (data->p_comm->c_flags & OMPI_COMM_NAMEISSET)
-        && data->p_comm->c_name && 0 <  strlen(data->p_comm->c_name)
+        && 0 <  strlen(data->p_comm->c_name)
         && 0 != strncmp(data->p_comm->c_name, data->comm_name, OPAL_MAX_OBJECT_NAME - 1) )
     {
         free(data->comm_name);
@@ -101,7 +101,9 @@ mca_monitoring_coll_data_t*mca_common_monitoring_coll_new( ompi_communicator_t*c
         return NULL;
     }
 
-    data->p_comm = comm;
+    data->procs     = NULL;
+    data->comm_name = NULL;
+    data->p_comm    = comm;
     
     /* Allocate hashtable */
     if( NULL == comm_data ) {

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ static opal_hash_table_t *comm_data = NULL;`
`47`	`47`	`static inline void mca_common_monitoring_coll_check_name(mca_monitoring_coll_data_t*data)`
`48`	`48`	`{`
`49`	`49`	`if( data->comm_name && data->p_comm && (data->p_comm->c_flags & OMPI_COMM_NAMEISSET)`
`50`		`- && data->p_comm->c_name && 0 < strlen(data->p_comm->c_name)`
	`50`	`+ && 0 < strlen(data->p_comm->c_name)`
`51`	`51`	`&& 0 != strncmp(data->p_comm->c_name, data->comm_name, OPAL_MAX_OBJECT_NAME - 1) )`
`52`	`52`	`{`
`53`	`53`	`free(data->comm_name);`
`@@ -101,7 +101,9 @@ mca_monitoring_coll_data_tmca_common_monitoring_coll_new( ompi_communicator_tc`
`101`	`101`	`return NULL;`
`102`	`102`	`}`
`103`	`103`
`104`		`- data->p_comm = comm;`
	`104`	`+ data->procs = NULL;`
	`105`	`+ data->comm_name = NULL;`
	`106`	`+ data->p_comm = comm;`
`105`	`107`
`106`	`108`	`/* Allocate hashtable */`
`107`	`109`	`if( NULL == comm_data ) {`