OSC/UCX: suppressed some coverity issues

- fixed return constant values

Signed-off-by: Sergey Oblomov <hoopoepg@gmail.com>

Author: hoopoepg

ompi/mca/osc/ucx/osc_ucx_comm.c

@@ -280,6 +280,11 @@ static inline int get_dynamic_win_info(uint64_t remote_addr,
     }
 
     temp_buf = calloc(remote_state_len, 1);
+    if (NULL == temp_buf) {
+        ret = OMPI_ERR_OUT_OF_RESOURCE;
+        goto cleanup;
+    }
+
     ret = opal_common_ucx_wpmem_putget(module->state_mem, OPAL_COMMON_UCX_GET, target,
                                        (void *)((intptr_t)temp_buf),
                                        remote_state_len, remote_state_addr, ep);
@@ -316,17 +321,20 @@ static inline int get_dynamic_win_info(uint64_t remote_addr,
     _mem_record_t *mem_rec = NULL;
     ret = opal_tsd_tracked_key_get(&module->mem->tls_key, (void **) &mem_rec);
     if (OPAL_SUCCESS != ret) {
+        ret = OMPI_ERROR;
         goto cleanup;
     }
 
      if (mem_rec == NULL) {
         OSC_UCX_GET_DEFAULT_EP(ep, module, target);
         ret = opal_common_ucx_tlocal_fetch_spath(module->mem, target, ep);
         if (OPAL_SUCCESS != ret) {
+            ret = OMPI_ERROR;
             goto cleanup;
         }
         ret = opal_tsd_tracked_key_get(&module->mem->tls_key, (void **) &mem_rec);
         if (OPAL_SUCCESS != ret) {
+            ret = OMPI_ERROR;
             goto cleanup;
         }
 
@@ -363,7 +371,7 @@ static inline int get_dynamic_win_info(uint64_t remote_addr,
     /* unlock the dynamic lock */
     ret_unlock = ompi_osc_ucx_dynamic_unlock(module, target);
     /* ignore unlock result in case of error */
-    return (OPAL_SUCCESS != ret) ? ret : ret_unlock;
+    return (OMPI_SUCCESS != ret) ? ret : ret_unlock;
 }
 
 static inline

ompi/mca/osc/ucx/osc_ucx_component.c

@@ -945,14 +945,14 @@ int ompi_osc_ucx_dynamic_lock(ompi_osc_ucx_module_t *module, int target) {
     uint64_t remote_addr = (module->state_addrs)[target] + OSC_UCX_STATE_DYNAMIC_LOCK_OFFSET;
     ucp_ep_h *ep;
     OSC_UCX_GET_DEFAULT_EP(ep, module, target);
-    int ret = OMPI_SUCCESS;
+    int ret;
 
     for (;;) {
         ret = opal_common_ucx_wpmem_cmpswp(module->state_mem,
                                         TARGET_LOCK_UNLOCKED, TARGET_LOCK_EXCLUSIVE,
                                         target, &result_value, sizeof(result_value),
                                         remote_addr, ep);
-        if (ret != OMPI_SUCCESS) {
+        if (OPAL_SUCCESS != ret) {
             OSC_UCX_VERBOSE(1, "opal_common_ucx_mem_cmpswp failed: %d", ret);
             return OMPI_ERROR;
         }
@@ -963,18 +963,18 @@ int ompi_osc_ucx_dynamic_lock(ompi_osc_ucx_module_t *module, int target) {
         opal_common_ucx_wpool_progress(mca_osc_ucx_component.wpool);
     }
 
-    return ret;
+    return OMPI_SUCCESS;
 }
 
 int ompi_osc_ucx_dynamic_unlock(ompi_osc_ucx_module_t *module, int target) {
     uint64_t result_value = -1;
     uint64_t remote_addr = (module->state_addrs)[target] + OSC_UCX_STATE_DYNAMIC_LOCK_OFFSET;
     ucp_ep_h *ep;
     OSC_UCX_GET_DEFAULT_EP(ep, module, target);
-    int ret = OMPI_SUCCESS;
+    int ret;
 
     ret = opal_common_ucx_wpmem_fence(module->mem);
-    if (ret != OMPI_SUCCESS) {
+    if (OPAL_SUCCESS != ret) {
         OSC_UCX_VERBOSE(1, "opal_common_ucx_mem_fence failed: %d", ret);
         return OMPI_ERROR;
     }
@@ -983,8 +983,12 @@ int ompi_osc_ucx_dynamic_unlock(ompi_osc_ucx_module_t *module, int target) {
                                     UCP_ATOMIC_FETCH_OP_SWAP, TARGET_LOCK_UNLOCKED,
                                     target, &result_value, sizeof(result_value),
                                     remote_addr, ep);
+    if (OPAL_SUCCESS != ret) {
+        return OMPI_ERROR;
+    }
+
     assert(result_value == TARGET_LOCK_EXCLUSIVE);
-    return ret;
+    return OMPI_SUCCESS;
 }
 
 int ompi_osc_ucx_win_attach(struct ompi_win_t *win, void *base, size_t len) {