linux: fix a warning about fgets return value not being used.

bgoglin · bgoglin · commit c3111cdb1719 · 2023-07-26T12:12:52.000+02:00
Reading /proc/cmdline will hardly fail anyway.

Signed-off-by: Brice Goglin &lt;Brice.Goglin@inria.fr&gt;
diff --git a/hwloc/topology-linux.c b/hwloc/topology-linux.c
@@ -5711,7 +5711,8 @@ hwloc_linuxfs_check_kernel_cmdline(struct hwloc_linux_backend_data_s *data)
     return;
 
   cmdline[0] = 0;
-  fgets(cmdline, sizeof(cmdline), file);
+  if (!fgets(cmdline, sizeof(cmdline), file))
+    goto out;
 
   fakenuma = strstr(cmdline, "numa=fake=");
   if (fakenuma) {
@@ -5730,6 +5731,7 @@ hwloc_linuxfs_check_kernel_cmdline(struct hwloc_linux_backend_data_s *data)
     hwloc_debug("Found fake numa %d\n", data->is_fake_numa_uniform);
   }
 
+ out:
   fclose(file);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5711,7 +5711,8 @@ hwloc_linuxfs_check_kernel_cmdline(struct hwloc_linux_backend_data_s *data)`
`5711`	`5711`	`return;`
`5712`	`5712`
`5713`	`5713`	`cmdline[0] = 0;`
`5714`		`- fgets(cmdline, sizeof(cmdline), file);`
	`5714`	`+ if (!fgets(cmdline, sizeof(cmdline), file))`
	`5715`	`+ goto out;`
`5715`	`5716`
`5716`	`5717`	`fakenuma = strstr(cmdline, "numa=fake=");`
`5717`	`5718`	`if (fakenuma) {`
`@@ -5730,6 +5731,7 @@ hwloc_linuxfs_check_kernel_cmdline(struct hwloc_linux_backend_data_s *data)`
`5730`	`5731`	`hwloc_debug("Found fake numa %d\n", data->is_fake_numa_uniform);`
`5731`	`5732`	`}`
`5732`	`5733`
	`5734`	`+ out:`
`5733`	`5735`	`fclose(file);`
`5734`	`5736`	`}`
`5735`	`5737`