INT-16127: Modify duplicated id's to avoid problems on the selects for open forums settings grade category

Author: Rafael Becerra

mod_form.php

@@ -238,7 +238,7 @@ function definition() {
                 $mform->disabledIf('advancedgradingmethod_'.$areaname, 'gradetype', 'neq', HSUFORUM_GRADETYPE_MANUAL);
             }
         }
-        $mform->disabledIf('gradepass', 'gradetype', 'neq', HSUFORUM_GRADETYPE_MANUAL);
+        $mform->disabledIf('gradepass_hsuforum', 'gradetype', 'neq', HSUFORUM_GRADETYPE_MANUAL);
 
         $reflection = new ReflectionClass($mform);
         $property = $reflection->getProperty('_hideifs');
@@ -252,7 +252,7 @@ function definition() {
                 $property->setValue($mform, $dependencies);
             }
         }
-        $mform->disabledIf('gradecat', 'gradetype', 'eq', HSUFORUM_GRADETYPE_NONE);
+        $mform->disabledIf('gradecat_hsuforum', 'gradetype', 'eq', HSUFORUM_GRADETYPE_NONE);
 //-------------------------------------------------------------------------------
 // buttons
         $this->add_action_buttons();
@@ -338,24 +338,24 @@ public function standard_hsuforum_grading_coursemodule_elements() {
             }
 
             if ($this->_features->gradecat) {
-                $mform->addElement('select', 'gradecat',
+                $mform->addElement('select', 'gradecat_hsuforum',
                     get_string('gradecategoryonmodform', 'grades'),
                     grade_get_categories_menu($COURSE->id, $this->_outcomesused));
-                $mform->addHelpButton('gradecat', 'gradecategoryonmodform', 'grades');
+                $mform->addHelpButton('gradecat_hsuforum', 'gradecategoryonmodform', 'grades');
                 if (!$this->_features->rating) {
-                    $mform->hideIf('gradecat', 'grade[modgrade_type]', 'eq', 'none');
+                    $mform->hideIf('gradecat_hsuforum', 'grade[modgrade_type]', 'eq', 'none');
                 }
             }
 
             // Grade to pass.
-            $mform->addElement('text', 'gradepass', get_string('gradepass', 'grades'));
-            $mform->addHelpButton('gradepass', 'gradepass', 'grades');
-            $mform->setDefault('gradepass', '');
-            $mform->setType('gradepass', PARAM_RAW);
+            $mform->addElement('text', 'gradepass_hsuforum', get_string('gradepass', 'grades'));
+            $mform->addHelpButton('gradepass_hsuforum', 'gradepass', 'grades');
+            $mform->setDefault('gradepass_hsuforum', '');
+            $mform->setType('gradepass_hsuforum', PARAM_RAW);
             if (!$this->_features->rating) {
-                $mform->hideIf('gradepass', 'grade[modgrade_type]', 'eq', 'none');
+                $mform->hideIf('gradepass_hsuforum', 'grade[modgrade_type]', 'eq', 'none');
             } else {
-                $mform->hideIf('gradepass', 'assessed', 'eq', '0');
+                $mform->hideIf('gradepass_hsuforum', 'assessed', 'eq', '0');
             }
         }
     }

tests/behat/add_forum.feature

@@ -45,3 +45,31 @@ Feature: Add Open Forum activities and discussions
     And I follow "Edit"
     And I follow "Use advanced editor and additional options"
     And the field "Attachment" matches value "empty.txt"
+
+  @javascript
+  Scenario: Display the grade category select according to the grade type options
+    Given the following "users" exist:
+      | username | firstname | lastname | email |
+      | teacher1 | Teacher | 1 | teacher1@example.com |
+    And the following "courses" exist:
+      | fullname | shortname | category |
+      | Course 1 | C1 | 0 |
+    And the following "course enrolments" exist:
+      | user | course | role |
+      | teacher1 | C1 | editingteacher |
+    And I log in as "teacher1"
+    And I am on "Course 1" course homepage with editing mode on
+    And I add a "Open Forum" to section "1" and I fill the form with:
+      | Forum name  | Test forum name                |
+      | Forum type  | Standard forum for general use |
+      | Description | Test forum description         |
+    And I follow "Test forum name"
+    And I click on "#region-main-settings-menu .dropdown-toggle>.icon" "css_element"
+    And I follow "Edit settings"
+    And I click on "#page-mod-hsuforum-mod #id_modstandardratings a[aria-controls='id_modstandardratings']" "css_element"
+    And I set the field with xpath "//body[@id='page-mod-hsuforum-mod']//fieldset[@id='id_modstandardratings']//select[@id='id_assessed']" to "Average of ratings"
+    And the "disabled" attribute of "#page-mod-hsuforum-mod #id_modstandardgrade > div.fcontainer.clearfix > div:nth-child(3) div[data-fieldtype='select'] select[name='gradecat_hsuforum']" "css_element" should contain "disabled"
+    And I click on "#page-mod-hsuforum-mod #id_modstandardgrade a[aria-controls='id_modstandardgrade']" "css_element"
+    And I set the field with xpath "//body[@id='page-mod-hsuforum-mod']//fieldset[@id='id_modstandardgrade']//select[@id='id_gradetype']" to "Manual"
+    # This final step is only to verify that the user can select something after the Manual option is chosen for grade type.
+    And I set the field with xpath "//body[@id='page-mod-hsuforum-mod']//fieldset[@id='id_modstandardgrade']//select[@id='id_gradecat_hsuforum']" to "Uncategorised"