INT-18716: PHP 8.1 Fixes

Author: jgg9026

classes/service/post_service.php

@@ -132,7 +132,7 @@ public function handle_user_autosubscription($forum, $post) {
      * @param array $options These override default post values, EG: set the post message with this
      * @return json_response
      */
-    public function handle_update_post($course, $cm, $forum, $context, $discussion, $post, array $deletefiles = array(), array $options) {
+    public function handle_update_post($course, $cm, $forum, $context, $discussion, $post, array $deletefiles = array(), array $options = []) {
 
         $this->require_can_edit_post($forum, $context, $discussion, $post);
 

lib.php

@@ -2157,7 +2157,7 @@ function hsuforum_get_readable_forums($userid, $courseid=0, $excludeanonymous =
  * @return array|bool Array of posts found or false
  */
 function hsuforum_search_posts($searchterms, $courseid=0, $limitfrom=0, $limitnum=50,
-                            &$totalcount, $extrasql='') {
+                            &$totalcount = 0, $extrasql='') {
     global $CFG, $DB, $USER;
     require_once($CFG->libdir.'/searchlib.php');
 

renderer.php

@@ -1917,7 +1917,7 @@ public function post_get_commands($post, $discussion, $cm, $canreply) {
      * @param int $discussion
      * @return string
      */
-    public function render_ax_button(moodle_url $url, $content, $method = 'post', $pinlink, $discussion) {
+    public function render_ax_button(moodle_url $url, $content, $method = 'post', $pinlink = 0, $discussion = 0) {
         global $PAGE;
 
         $PAGE->requires->js_call_amd('mod_hsuforum/accessibility', 'init', array());