INT-18599: Fix simple text format

Author: fabianbatioja

lib.php

@@ -8806,6 +8806,25 @@ function hsuforum_check_updates_since(cm_info $cm, $from, $filter = array()) {
     return $updates;
 }
 
+/**
+ * Update the post format to the preferred format.
+ * @param $messagecontent
+ * @param $prefilledpostformat
+ * @param $modcontext
+ * @return mixed|string
+ */
+function hsuforum_change_format($messagecontent, $prefilledpostformat, $modcontext) {
+    $preferredformat = editors_get_preferred_format();
+    // Only if there are prefilled contents coming.
+    if (!empty($messagecontent)) {
+        // If the prefilled post is not HTML and the preferred format is HTML, convert to it.
+        if ($prefilledpostformat != FORMAT_HTML and $preferredformat == FORMAT_HTML) {
+            $messagecontent = format_text($messagecontent, $prefilledpostformat, ['context' => $modcontext]);
+        }
+    }
+    return $messagecontent;
+}
+
 /**
  * Check if the user can create attachments in a forum.
  * @param  stdClass $forum   forum object

post.php

@@ -117,6 +117,7 @@
     // Retrieve the contexts.
     $modcontext    = context_module::instance($cm->id);
     $coursecontext = context_course::instance($course->id);
+    $PAGE->set_cm($cm, $course, $forum);
 
     if (! hsuforum_user_can_post_discussion($forum, $groupid, -1, $cm)) {
         if (!isguestuser()) {
@@ -139,6 +140,7 @@
 
     $SESSION->fromurl = get_local_referer(false);
 
+    $messagecontent = hsuforum_change_format($messagecontent, $prefilledpostformat, $modcontext);
     // Load up the $post variable.
 
     $post = new stdClass();
@@ -222,14 +224,7 @@
         print_error("activityiscurrentlyhidden");
     }
 
-    $preferredformat = editors_get_preferred_format();
-    // Only if there are prefilled contents coming.
-    if (!empty($messagecontent)) {
-        // If the prefilled post is not HTML and the preferred format is HTML, convert to it.
-        if ($prefilledpostformat != FORMAT_HTML and $preferredformat == FORMAT_HTML) {
-            $messagecontent = format_text($messagecontent, $prefilledpostformat, ['context' => $modcontext]);
-        }
-    }
+    $messagecontent = hsuforum_change_format($messagecontent, $prefilledpostformat, $modcontext);
     // Load up the $post variable.
 
     $post = new stdClass();