INT-16757: Fix cache error on upgrade path and reapply INT-11037 from lib/behat/behat_base.php, setUp functions fixed and deprecated messages

Author: jgg9026

tests/events_test.php

@@ -38,7 +38,7 @@ class mod_hsuforum_events_testcase extends advanced_testcase {
     /**
      * Tests set up.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest();
     }
 

tests/externallib_test.php

@@ -35,7 +35,7 @@ class mod_hsuforum_external_testcase extends externallib_advanced_testcase {
     /**
      * Tests set up
      */
-    protected function setUp() {
+    protected function setUp():void {
         global $CFG;
 
         require_once($CFG->dirroot . '/mod/hsuforum/lib.php');

tests/mail_test.php

@@ -31,7 +31,7 @@ class mod_hsuforum_mail_testcase extends advanced_testcase {
 
     protected $helper;
 
-    public function setUp() {
+    public function setUp(): void {
 
         global $CFG;
         require_once($CFG->dirroot . '/mod/hsuforum/lib.php');

tests/maildigest_test.php

@@ -47,7 +47,7 @@ class mod_hsuforum_maildigest_testcase extends advanced_testcase {
      * Set up message and mail sinks, and set up other requirements for the
      * cron to be tested here.
      */
-    public function setUp() {
+    public function setUp(): void {
         global $CFG;
 
         $this->helper = new stdClass();

tests/privacy_provider_test.php

@@ -54,7 +54,7 @@ class mod_hsuforum_privacy_provider_testcase extends \core_privacy\tests\provide
     /**
      * Test setUp.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }
 

tests/search_test.php

@@ -45,7 +45,7 @@ class mod_hsuforum_search_testcase extends advanced_testcase {
      */
     protected $forumpostareaid = null;
 
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
         set_config('enableglobalsearch', true);