Skip to content

fix: Added Locale.ENGLISH to SimpleDateFormat for parsing the Last-Modified HTTP header #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: Added Locale.ENGLISH to SimpleDateFormat for parsing the Last-Modified HTTP header #1626

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5dc396
Specify Locale for Last-Modified header formatter
kuaikuai Nov 12, 2025
17f8c20
Add import for Locale in GoFeatureFlagApi
kuaikuai Nov 12, 2025
15e96d8
Refactor Last-Modified header parsing logic
kuaikuai Nov 13, 2025
5f72ec8
Fix formatting of log debug statement
kuaikuai Nov 13, 2025
c6f7a3a
Update GoFeatureFlagApi.java
kuaikuai Nov 18, 2025
8d0f997
Refactor date formatter initialization for clarity
kuaikuai Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions ...g/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
import java.net.http.HttpResponse;
import java.text.SimpleDateFormat;
import java.time.Duration;
import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeParseException;
import java.util.Collections;
import java.util.Date;
import java.util.List;
Expand Down Expand Up @@ -280,14 +283,20 @@ private FlagConfigResponse handleFlagConfigurationSuccess(final HttpResponse<Str
* @return Date - the parsed Last-Modified date, or null if not present or parsing fails
*/
private Date extractLastUpdatedFromHeaders(final HttpResponse<String> response) {
Optional<String> headerOpt = response.headers()
.firstValue(Const.HTTP_HEADER_LAST_MODIFIED);
if (!headerOpt.isPresent()) {
log.debug("Last-Modified header is not present in the response");
return null;
}
String headerValue = headerOpt.get();
try {
String headerValue = response.headers()
.firstValue(Const.HTTP_HEADER_LAST_MODIFIED)
.orElse(null);
SimpleDateFormat lastModifiedHeaderFormatter = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz");
return headerValue != null ? lastModifiedHeaderFormatter.parse(headerValue) : null;
} catch (Exception e) {
log.debug("Error parsing Last-Modified header: {}", e.getMessage());
return Date.from(
ZonedDateTime.parse(headerValue, DateTimeFormatter.RFC_1123_DATE_TIME)
.toInstant()
);
} catch (DateTimeParseException e) {
log.debug("Failed to parse Last-Modified header: '{}'. Cause: {}", headerValue, e.getMessage());
return null;
}
}
Expand Down
Loading