chore(deps): update dependency com.github.spotbugs:spotbugs to v4.9.8 (#1575)

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Simon Schrottner <simon.schrottner@dynatrace.com>

Author: renovate[bot]

pom.xml

@@ -117,7 +117,7 @@
             <!-- used so that lombok can generate suppressions for spotbugs. It needs to find it on the relevant classpath -->
             <groupId>com.github.spotbugs</groupId>
             <artifactId>spotbugs</artifactId>
-            <version>4.8.6</version>
+            <version>4.9.8</version>
             <scope>provided</scope>
         </dependency>
 
@@ -467,7 +467,7 @@
                             <dependency>
                                 <groupId>com.github.spotbugs</groupId>
                                 <artifactId>spotbugs</artifactId>
-                                <version>4.9.0</version>
+                                <version>4.9.8</version>
                             </dependency>
                         </dependencies>
                         <executions>

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/QueueingStreamObserver.java

@@ -10,7 +10,7 @@
  */
 @Slf4j
 @SuppressFBWarnings(
-        value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"},
+        value = {"EI_EXPOSE_REP"},
         justification = "Internal class")
 public class QueueingStreamObserver<T> implements StreamObserver<T> {
     private final BlockingQueue<StreamResponseModel<T>> blockingQueue;

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java

@@ -9,7 +9,6 @@
 import com.networknt.schema.JsonSchemaFactory;
 import com.networknt.schema.SpecVersion;
 import com.networknt.schema.ValidationMessage;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.net.URI;
 import java.util.HashMap;
@@ -23,9 +22,6 @@
 
 /** flagd feature flag configuration parser. */
 @Slf4j
-@SuppressFBWarnings(
-        value = {"EI_EXPOSE_REP"},
-        justification = "Feature flag comes as a Json configuration, hence they must be exposed")
 public class FlagParser {
     private static final String FLAG_KEY = "flags";
     private static final String METADATA_KEY = "metadata";

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java

@@ -32,7 +32,7 @@
  */
 @Slf4j
 @SuppressFBWarnings(
-        value = {"PREDICTABLE_RANDOM", "EI_EXPOSE_REP"},
+        value = {"EI_EXPOSE_REP"},
         justification = "Random is used to generate a variation & flag configurations require exposing")
 public class SyncStreamQueueSource implements QueueSource {
     private static final int QUEUE_SIZE = 5;

providers/flagsmith/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderOptions.java

@@ -15,7 +15,7 @@
 
 /** FlagsmithProviderOptions contains the options to initialise the Flagsmith provider. */
 @SuppressFBWarnings(
-        value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"},
+        value = {"EI_EXPOSE_REP"},
         justification = "The headers need to be mutable")
 @Builder(toBuilder = true)
 @Getter

tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/HttpConnectorOptions.java

@@ -19,7 +19,7 @@
  * Represents configuration options for the HTTP connector.
  */
 @SuppressFBWarnings(
-        value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2", "CT_CONSTRUCTOR_THROW"},
+        value = {"EI_EXPOSE_REP", "CT_CONSTRUCTOR_THROW"},
         justification = "builder validations")
 @Slf4j
 @Getter

tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/PayloadCacheOptions.java

@@ -1,6 +1,5 @@
 package dev.openfeature.contrib.tools.flagd.resolver.process.storage.connector.sync.http;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import lombok.Builder;
 import lombok.Getter;
 
@@ -16,9 +15,6 @@
  * corner cases.
  * </p>
  */
-@SuppressFBWarnings(
-        value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"},
-        justification = "builder validations")
 @Builder
 @Getter
 public class PayloadCacheOptions {