Fix PHPStan issues level 5 - Close #38

Author: sandrokeil

phpstan.neon.dist

@@ -1,4 +1,4 @@
 parameters:
-  level: 3
+  level: 5
   paths:
     - src/

src/Code/ClassConstGenerator.php

@@ -21,7 +21,7 @@ final class ClassConstGenerator extends AbstractMemberGenerator
 
     /**
      * @param string $name
-     * @param ValueGenerator|string|array $value
+     * @param ValueGenerator|mixed $value
      * @param int $flags
      */
     public function __construct(string $name, $value, $flags = self::FLAG_PUBLIC)

src/Code/ClassGenerator.php

@@ -37,7 +37,7 @@ final class ClassGenerator implements StatementGenerator
 
     /**
      * @param  string|null $name
-     * @param  array|string $flags
+     * @param  array|int $flags
      */
     public function __construct(
         ?string $name,

src/Code/ParameterGenerator.php

@@ -33,7 +33,7 @@ final class ParameterGenerator
     private $type;
 
     /**
-     * @var ValueGenerator
+     * @var ValueGenerator|null
      */
     private $defaultValue;
 
@@ -117,7 +117,7 @@ public function getName(): string
      *
      * Certain variables are difficult to express
      *
-     * @param  null|bool|string|int|float|array|ValueGenerator $defaultValue
+     * @param  ValueGenerator|mixed $defaultValue
      * @return ParameterGenerator
      */
     public function setDefaultValue($defaultValue): self
@@ -130,10 +130,7 @@ public function setDefaultValue($defaultValue): self
         return $this;
     }
 
-    /**
-     * @return ValueGenerator
-     */
-    public function getDefaultValue(): ValueGenerator
+    public function getDefaultValue(): ?ValueGenerator
     {
         return $this->defaultValue;
     }
@@ -195,6 +192,7 @@ public function setTypeDocBlockHint(?string $typeDocBlockHint): void
 
     public function generate(): Node\Param
     {
+        // @phpstan-ignore-next-line
         return new Node\Param(
             new Node\Expr\Variable($this->name),
             $this->defaultValue ? $this->defaultValue->generate() : null,

src/Code/PropertyGenerator.php

@@ -32,7 +32,7 @@ final class PropertyGenerator extends AbstractMemberGenerator
     private $type;
 
     /**
-     * @var ValueGenerator
+     * @var ValueGenerator|null
      */
     private $defaultValue;
 
@@ -133,10 +133,7 @@ public function setDefaultValue(
         return $this;
     }
 
-    /**
-     * @return ValueGenerator
-     */
-    public function getDefaultValue(): ValueGenerator
+    public function getDefaultValue(): ?ValueGenerator
     {
         return $this->defaultValue;
     }
@@ -156,6 +153,7 @@ public function setTypeDocBlockHint(?string $typeDocBlockHint): void
 
     public function generate(): Property
     {
+        // @phpstan-ignore-next-line
         return new Property(
             $this->flags,
             [

src/NodeVisitor/ClassNamespace.php

@@ -11,6 +11,7 @@
 namespace OpenCodeModeling\CodeAst\NodeVisitor;
 
 use PhpParser\BuilderFactory;
+use PhpParser\Node;
 use PhpParser\Node\Stmt;
 use PhpParser\NodeVisitorAbstract;
 
@@ -57,7 +58,7 @@ public function afterTraverse(array $nodes): ?array
         return $newNodes;
     }
 
-    private function isNodeStrictType(Stmt $node): bool
+    private function isNodeStrictType(Node $node): bool
     {
         return $node instanceof Stmt\Declare_
             && \strtolower($node->declares[0]->key->name) === 'strict_types';