Merge pull request #10 from oozou/terraform-test

test workflow

Author: lycbrian

.github/workflows/terraform-test.yaml

@@ -36,25 +36,41 @@ jobs:
     permissions:
       pull-requests: write
     steps:
-      - name: Comment on PR
+      - name: Report failed jobs
         uses: actions/github-script@v7
         with:
-          github-token: ${{ secrets.CICD_GH_PAT }}  # 👈 MUST be inside 'with', not 'env'
+          github-token: ${{ secrets.CICD_GH_PAT }}
           script: |
-            const buildUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;
-            const comment = `@claude fix build error:
-            
-            The Terraform tests have failed. Please check the build logs for details.
-            
-            **Build Link:** ${buildUrl}
-            
-            **Failed Job:** ${{ needs.test.result }}
-            
-            Please review the test failures and fix any issues before merging.`;
-            
-            github.rest.issues.createComment({
-              issue_number: context.issue.number,
+            const run_id = process.env.GITHUB_RUN_ID;
+            const { data: jobs } = await github.rest.actions.listJobsForWorkflowRun({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              body: comment
+              run_id: run_id
             });
+
+            const failedJobs = jobs.jobs
+              .filter(job => job.conclusion === 'failure')
+              .map(job => `- ${job.name} (Job ID: ${job.id})`)
+              .join('\n');
+
+            if (!failedJobs) {
+              core.info("No failed jobs found.");
+              return;
+            }
+
+            const prNumber = context.payload.pull_request?.number;
+            if (!prNumber) {
+              core.warning("Not a pull request context.");
+              return;
+            }
+
+            const commentBody = `@claude ### ❌ Failed Jobs in Workflow Run #${run_id}\n${failedJobs}`;
+
+            await github.rest.issues.createComment({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: prNumber,
+              body: commentBody
+            });
+
+            core.info("Posted PR comment with failed jobs.");

examples/terraform-test/main.tf

@@ -84,7 +84,7 @@ module "valkey_traditional" {
     port           = 6379,
     instance_type  = "cache.t3.micro",
     engine_version = "7.2",
-    node_count     = 1
+    node_count     = 2
   }
 
   auth_token = "TIdAao6sd6waZ6NpiC60RZ2nRqYf7C3b"

tests/terraform_test.go

@@ -57,6 +57,12 @@ func TestTerraformAWSElastiCacheModule(t *testing.T) {
 		EnvVars: map[string]string{
 			"AWS_DEFAULT_REGION": awsRegion,
 		},
+
+		// Variables to pass to our Terraform code using -var options
+		Vars: map[string]interface{}{
+			"prefix":      "example",
+			"environment": "example",
+		},
 	})
 
 	// At the end of the test, run `terraform destroy` to clean up any resources that were created
@@ -182,6 +188,7 @@ func testElasticacheClustersCreated(t *testing.T, terraformOptions *terraform.Op
 		assert.Equal(t, "valkey", *rg.Engine, "Engine should be valkey")
 		assert.True(t, *rg.AtRestEncryptionEnabled, "At-rest encryption should be enabled")
 		assert.True(t, *rg.TransitEncryptionEnabled, "Transit encryption should be enabled")
+		// assert.Equal(t, "enabled", string(rg.MultiAZ), "Multi-AZ should be enabled for Valkey cluster")
 	}
 }
 
@@ -239,7 +246,7 @@ func testAlarmsCreated(t *testing.T, terraformOptions *terraform.Options, region
 	// Test alarms for Redis traditional cluster
 	if redisReplicationGroupId != "" {
 		input := &cloudwatch.DescribeAlarmsInput{
-			AlarmNamePrefix: aws.String(fmt.Sprintf("example-example-redis-test-redis_high_CPU")),
+			AlarmNamePrefix: aws.String("example-example-redis-test-redis_high_CPU"),
 		}
 
 		result, err := client.DescribeAlarms(context.TODO(), input)
@@ -261,7 +268,7 @@ func testAlarmsCreated(t *testing.T, terraformOptions *terraform.Options, region
 	// Test alarms for Valkey traditional cluster
 	if valkeyReplicationGroupId != "" {
 		input := &cloudwatch.DescribeAlarmsInput{
-			AlarmNamePrefix: aws.String(fmt.Sprintf("example-example-valkey-test-redis_high_CPU")),
+			AlarmNamePrefix: aws.String("example-example-valkey-test-redis_high_CPU"),
 		}
 
 		result, err := client.DescribeAlarms(context.TODO(), input)