Skip to content

update set initial value without dataset #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update set initial value without dataset #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ export const AutocompleteDropdown = memo<
matchFrom,
inputHeight = moderateScale(40, 0.2),
suggestionsListMaxHeight = moderateScale(200, 0.2),
// bottomOffset = 0,
direction: directionProp,
controller,
onSelectItem: onSelectItemProp,
Expand Down Expand Up @@ -95,7 +94,6 @@ export const AutocompleteDropdown = memo<
const [selectedItem, setSelectedItem] = useState<AutocompleteDropdownItem | null>(null)
const [isOpened, setIsOpened] = useState(false)
const initialDataSetRef = useRef<AutocompleteDropdownItem[] | null>(dataSetProp)
const initialValueRef = useRef(initialValueProp)
const [dataSet, setDataSet] = useState(dataSetProp)
const matchFromStart = matchFrom === 'start' ? true : false
const {
Expand Down Expand Up @@ -188,24 +186,10 @@ export const AutocompleteDropdown = memo<

/** Set initial value */
useEffect(() => {
const initialDataSet = initialDataSetRef.current
const initialValue = initialValueRef.current

let initialValueItem: AutocompleteDropdownItem | undefined
if (typeof initialValue === 'string') {
initialValueItem = initialDataSet?.find(el => el.id === initialValue)
} else if (typeof initialValue === 'object' && initialValue.id) {
initialValueItem = initialDataSet?.find(el => el.id === initialValue?.id)
if (!initialValueItem) {
// set the item as it is if it's not in the list
initialValueItem = initialValue
}
if (initialValueProp && typeof initialValueProp === 'object' && selectedItem?.id !== initialValueProp.id) {
setSelectedItem(initialValueProp);
}

if (initialValueItem) {
setSelectedItem(initialValueItem)
}
}, [])
}, [initialValueProp]);

useEffect(() => {
return () => {
Expand Down Expand Up @@ -496,7 +480,7 @@ export const AutocompleteDropdown = memo<
style={[styles.container, containerStyle]}>
<View
ref={containerRef}
onLayout={_ => {}} // it's necessary use onLayout here for Androd (bug?)
onLayout={_ => { }} // it's necessary use onLayout here for Androd (bug?)
style={[styles.inputContainerStyle, inputContainerStyle]}>
{LeftComponent}
<Pressable
Expand Down