Skip to content

Commit 848c6df

Browse files
committed
chore(models/Report): fix reportIncompatibleMethodOverride lints
This check is currently turned off in our `basic` `typeCheckingMode` profile, but is enabled in the `standard` profile. Things done here: - matched the signature of `default` with `JSONEncoder.default` Error: unblob/models.py unblob/models.py:258:9 - error: Method "default" overrides class "JSONEncoder" in an incompatible manner   Parameter 2 name mismatch: base parameter is named "o", override parameter is named "obj" (reportIncompatibleMethodOverride)
1 parent cfd4dd2 commit 848c6df

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

unblob/models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,8 @@ def get_output_dir(self) -> Optional[Path]:
255255

256256

257257
class _JSONEncoder(json.JSONEncoder):
258-
def default(self, obj):
258+
def default(self, o):
259+
obj = o
259260
if attrs.has(type(obj)):
260261
extend_attr_output = True
261262
attr_output = attrs.asdict(obj, recurse=not extend_attr_output)

0 commit comments

Comments
 (0)