chore(ruff): fix false positive function-call-in-dataclass-default-argument lints

The following lints are false positive, but highlight a problem:

    178 | @attrs.define
    179 | class MultiFile(Blob):
    180 |     name: str = attr.field(kw_only=True)
        |                 ^^^^^^^^^^^^^^^^^^^^^^^^ RUF009
    181 |     paths: list[Path] = attr.field(kw_only=True)
        |

    unblob/models.py:181:25: RUF009 Do not perform function call `attr.field` in dataclass defaults
        |
    179 | class MultiFile(Blob):
    180 |     name: str = attr.field(kw_only=True)
    181 |     paths: list[Path] = attr.field(kw_only=True)
        |                         ^^^^^^^^^^^^^^^^^^^^^^^^ RUF009
    182 |
    183 |     handler: "DirectoryHandler" = attr.ib(init=False, eq=False)
        |

The issue is that we are using both `attrs` and legacy `attr` module
imports in the same scope.

Fixing these also introduce invalid `attrs.ib` calls as well, which
also has to be fixed

Author: vlaci

unblob/models.py

@@ -6,7 +6,6 @@
 from pathlib import Path
 from typing import Optional, TypeVar
 
-import attr
 import attrs
 from structlog import get_logger
 
@@ -31,22 +30,22 @@
 #
 
 
-@attr.define(frozen=True)
+@attrs.define(frozen=True)
 class Task:
     path: Path
     depth: int
     blob_id: str
-    is_multi_file: bool = attr.field(default=False)
+    is_multi_file: bool = attrs.field(default=False)
 
 
-@attr.define
+@attrs.define
 class Blob:
-    id: str = attr.field(
+    id: str = attrs.field(
         factory=new_id,
     )
 
 
-@attr.define
+@attrs.define
 class Chunk(Blob):
     """File chunk, have start and end offset, but still can be invalid.
 
@@ -56,10 +55,10 @@ class Chunk(Blob):
         b[c.start_offset:c.end_offset]
     """
 
-    start_offset: int = attr.field(kw_only=True)
+    start_offset: int = attrs.field(kw_only=True)
     """The index of the first byte of the chunk"""
 
-    end_offset: int = attr.field(kw_only=True)
+    end_offset: int = attrs.field(kw_only=True)
     """The index of the first byte after the end of the chunk"""
 
     file: Optional[File] = None
@@ -101,12 +100,12 @@ def __repr__(self) -> str:
         return self.range_hex
 
 
-@attr.define(repr=False)
+@attrs.define(repr=False)
 class ValidChunk(Chunk):
     """Known to be valid chunk of a File, can be extracted with an external program."""
 
-    handler: "Handler" = attr.ib(init=False, eq=False)
-    is_encrypted: bool = attr.ib(default=False)
+    handler: "Handler" = attrs.field(init=False, eq=False)
+    is_encrypted: bool = attrs.field(default=False)
 
     def extract(self, inpath: Path, outdir: Path) -> Optional["ExtractResult"]:
         if self.is_encrypted:
@@ -131,7 +130,7 @@ def as_report(self, extraction_reports: list[Report]) -> ChunkReport:
         )
 
 
-@attr.define(repr=False)
+@attrs.define(repr=False)
 class UnknownChunk(Chunk):
     r"""Gaps between valid chunks or otherwise unknown chunks.
 
@@ -152,7 +151,7 @@ def as_report(self, randomness: Optional[RandomnessReport]) -> UnknownChunkRepor
         )
 
 
-@attr.define(repr=False)
+@attrs.define(repr=False)
 class PaddingChunk(Chunk):
     r"""Gaps between valid chunks or otherwise unknown chunks.
 
@@ -177,10 +176,10 @@ def as_report(
 
 @attrs.define
 class MultiFile(Blob):
-    name: str = attr.field(kw_only=True)
-    paths: list[Path] = attr.field(kw_only=True)
+    name: str = attrs.field(kw_only=True)
+    paths: list[Path] = attrs.field(kw_only=True)
 
-    handler: "DirectoryHandler" = attr.ib(init=False, eq=False)
+    handler: "DirectoryHandler" = attrs.field(init=False, eq=False)
 
     def extract(self, outdir: Path) -> Optional["ExtractResult"]:
         return self.handler.extract(self.paths, outdir)
@@ -198,11 +197,11 @@ def as_report(self, extraction_reports: list[Report]) -> MultiFileReport:
 ReportType = TypeVar("ReportType", bound=Report)
 
 
-@attr.define
+@attrs.define
 class TaskResult:
     task: Task
-    reports: list[Report] = attr.field(factory=list)
-    subtasks: list[Task] = attr.field(factory=list)
+    reports: list[Report] = attrs.field(factory=list)
+    subtasks: list[Task] = attrs.field(factory=list)
 
     def add_report(self, report: Report):
         self.reports.append(report)
@@ -214,9 +213,9 @@ def filter_reports(self, report_class: type[ReportType]) -> list[ReportType]:
         return [report for report in self.reports if isinstance(report, report_class)]
 
 
-@attr.define
+@attrs.define
 class ProcessResult:
-    results: list[TaskResult] = attr.field(factory=list)
+    results: list[TaskResult] = attrs.field(factory=list)
 
     @property
     def errors(self) -> list[ErrorReport]:
@@ -257,9 +256,9 @@ def get_output_dir(self) -> Optional[Path]:
 
 class _JSONEncoder(json.JSONEncoder):
     def default(self, obj):
-        if attr.has(type(obj)):
+        if attrs.has(type(obj)):
             extend_attr_output = True
-            attr_output = attr.asdict(obj, recurse=not extend_attr_output)
+            attr_output = attrs.asdict(obj, recurse=not extend_attr_output)
             attr_output["__typename__"] = obj.__class__.__name__
             return attr_output
 
@@ -295,7 +294,7 @@ def __init__(self, *reports: Report):
         self.reports: tuple[Report, ...] = reports
 
 
-@attr.define(kw_only=True)
+@attrs.define(kw_only=True)
 class ExtractResult:
     reports: list[Report]