Add utils_get_size_threshold() with tests

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

Author: ldorau

src/proxy_lib/proxy_lib.c

@@ -142,31 +142,7 @@ static __TLS int was_called_from_malloc_usable_size = 0;
 #ifndef _WIN32
 static size_t get_size_threshold(void) {
     char *str_threshold = utils_env_var_get_str("UMF_PROXY", "size.threshold=");
-    if (!str_threshold) {
-        return 0;
-    }
-
-    // move to the beginning of the number
-    str_threshold += strlen("size.threshold=");
-    // find ';' at the end
-    char *end = strstr(str_threshold, ";");
-    if (end) {
-        // replace ';' with '\0' to mark end of the string
-        *end = '\0';
-    }
-
-    long long_threshold = atol(str_threshold);
-    if (long_threshold < 0) {
-        LOG_ERR("size threshold cannot be negative! = (char *) %s, (int) %li",
-                str_threshold, long_threshold);
-        return 0;
-    }
-
-    size_t int_threshold = (size_t)long_threshold;
-    LOG_DEBUG("Size_threshold_value = (char *) %s, (int) %zu", str_threshold,
-              int_threshold);
-
-    return int_threshold;
+    return utils_get_size_threshold(str_threshold);
 }
 
 static int get_system_allocator_symbols(void) {

src/utils/utils_common.h

@@ -168,6 +168,8 @@ int utils_file_open_or_create(const char *path);
 
 int utils_fallocate(int fd, long offset, long len);
 
+size_t utils_get_size_threshold(char *str_threshold);
+
 #ifdef __cplusplus
 }
 #endif

src/utils/utils_posix_common.c

@@ -266,3 +266,27 @@ int utils_file_open_or_create(const char *path) {
 
     return fd;
 }
+
+// Expected input:
+// char *str_threshold = utils_env_var_get_str("UMF_PROXY", "size.threshold=");
+size_t utils_get_size_threshold(char *str_threshold) {
+    if (!str_threshold) {
+        return 0;
+    }
+
+    // move to the beginning of the number
+    str_threshold += strlen("size.threshold=");
+
+    long long_threshold = atol(str_threshold);
+    if (long_threshold < 0) {
+        LOG_ERR("size threshold cannot be negative! = (char *) %s, (int) %li",
+                str_threshold, long_threshold);
+        return 0;
+    }
+
+    size_t int_threshold = (size_t)long_threshold;
+    LOG_DEBUG("Size_threshold_value = (char *) %s, (int) %zu", str_threshold,
+              int_threshold);
+
+    return int_threshold;
+}

src/utils/utils_windows_common.c

@@ -215,3 +215,10 @@ int utils_fallocate(int fd, long offset, long len) {
 
     return -1;
 }
+
+// Expected input:
+// char *str_threshold = utils_env_var_get_str("UMF_PROXY", "size.threshold=");
+size_t utils_get_size_threshold(char *str_threshold) {
+    (void)str_threshold; // unused
+    return 0;
+}

test/utils/utils_linux.cpp

@@ -56,3 +56,17 @@ TEST_F(test, utils_shm_create_invalid_args) {
     ret = utils_shm_create("/abc", -1);
     EXPECT_EQ(ret, -1);
 }
+
+TEST_F(test, utils_get_size_threshold) {
+    // Expected input to utils_get_size_threshold():
+    // char *str_threshold = utils_env_var_get_str("UMF_PROXY", "size.threshold=");
+    // positive tests
+    EXPECT_EQ(utils_get_size_threshold((char *)"size.threshold=111"), 111);
+    EXPECT_EQ(utils_get_size_threshold((char *)"size.threshold=222;abcd"), 222);
+    EXPECT_EQ(utils_get_size_threshold((char *)"size.threshold=333;var=value"),
+              333);
+    // negative tests
+    EXPECT_EQ(utils_get_size_threshold(NULL), 0);
+    EXPECT_EQ(utils_get_size_threshold((char *)"size.threshold=abc"), 0);
+    EXPECT_EQ(utils_get_size_threshold((char *)"size.threshold=-1"), 0);
+}