Syntax to apply only machine-applicable fixes

[smoelius]

I am try to add two suggestions to Clippy's return_self_not_must_use lint:

• a suggestion to add #[must_use] to the function, which should be machine applicable
• a suggestion to add #[must_use] to Self, which should be unspecified

The problem I face is that ui_test applies both suggestions. How do I get it to apply just the machine applicable suggestion?

I found this code in ui_test:

ui_test/src/custom_flags/rustfix.rs

Lines 44 to 58 in 67eccdb

	fn post_test_action(
	&self,
	config: &TestConfig,
	output: &Output,
	build_manager: &BuildManager,
	) -> Result<(), Errored> {
	let global_rustfix = match config.exit_status()? {
	Some(Spanned {
	content: 101 | 0, ..
	}) => RustfixMode::Disabled,
	_ => *self,
	};
	let output = output.clone();
	let no_run_rustfix = config.find_one_custom("no-rustfix")?;
	let fixes = if no_run_rustfix.is_none() && global_rustfix.enabled() {

Adding a dbg!(*self) suggests that *self is Everything. But I cannot figure out how to set *self to something else.

Also, Clippy's redundant_clone ui test has the following line, but I'm not sure it does anything: https://github.com/rust-lang/rust-clippy/blob/cb56d63b8853fc052df6539da14c2c1a7e2be96e/tests/ui/redundant_clone.rs#L1

If I change that line to // rustfix-only-machine-applicablexxx and run TESTNAME=redundant_clone cargo uibless, the corresponding line in the .fixed file changes, but nothing else does.

[oli-obk]

yea I've encountered this before, too. Sounds like a good change to me

[smoelius]

What sort of syntax would you imagine?

Is there an existing change that adds a similar feature that I might crib from?

[smoelius]

So I have a file that looks like this:

//@rustfix-mode: disabled
#![allow(dead_code)]

pub static x: u32 = 0;

mod internal {
    pub static y: u32 = 0;
}

fn main() {}

My intent is to run this file with //@rustfix-mode: disabled, //@rustfix-mode: everything, etc.

But I am having a hard time figuring out where to put this file. Any suggestions?

[oli-obk]

I like the new flag.

You're asking where to put the test? https://github.com/oli-obk/ui_test/tree/main/tests/integrations/basic/tests/actual_tests is where all usual tests live. Only when testing ui_test failures or some special cases do we need the others (I should document this)

[smoelius]

If I put the tests in that directory, they will be run from here?

ui_test/src/per_test_config.rs

Line 389 in 2a32015

flag.post_test_action(self, &output, build_manager)?;

[oli-obk]

Well indirectly, yes, but so would all other tests. Whats the reason you're asking this question? I want to avoid an XY problem 😉

[smoelius]

I just pushed a very messy branch #353.

Long story short, I cannot figure out how to get the tests to run. I am not even sure that I modified the right parts of the code. So any help would be appreciated.