refactor: use Shell Arithmetic comparison instead of Conditional Expressions 🔢

Author: oldratlee

bin/a2l

@@ -46,7 +46,7 @@ progVersion() {
 ################################################################################
 
 declare -a args=()
-while [ $# -gt 0 ]; do
+while (($# > 0)); do
   case "$1" in
   -h | --help)
     usage

bin/ap

@@ -106,7 +106,7 @@ progVersion() {
 ################################################################################
 
 declare -a files=()
-while [ $# -gt 0 ]; do
+while (($# > 0)); do
   case "$1" in
   -h | --help)
     usage

bin/c

@@ -86,7 +86,7 @@ progVersion() {
 quiet=false
 keep_eol=false
 declare -a target_command=()
-while [ $# -gt 0 ]; do
+while (($# > 0)); do
   case "$1" in
   -k | --keep-eol)
     keep_eol=true
@@ -156,7 +156,7 @@ teeAndCopy() {
   fi
 }
 
-if [ ${#target_command[@]} -eq 0 ]; then
+if ((${#target_command[@]} == 0)); then
   teeAndCopy
 else
   "${target_command[@]}" | teeAndCopy

bin/coat

@@ -47,7 +47,7 @@ colorLines() {
   [ -z "$line" ] || rotateColorPrint "$line"
 }
 
-if [ $# == 0 ]; then
+if (($# == 0)); then
   colorLines
 else
   cat "$@" | colorLines

bin/rp

@@ -105,7 +105,7 @@ progVersion() {
 ################################################################################
 
 declare -a files=()
-while [ $# -gt 0 ]; do
+while (($# > 0)); do
   case "$1" in
   -h | --help)
     usage
@@ -129,9 +129,9 @@ while [ $# -gt 0 ]; do
   esac
 done
 
-[ ${#files[@]} -eq 0 ] && die "NO argument!"
+((${#files[@]} == 0)) && die "NO argument!"
 
-if [ ${#files[@]} -eq 1 ]; then
+if ((${#files[@]} == 1)); then
   relativeTo=.
 else
   argc=${#files[@]}

bin/xpl

@@ -78,7 +78,7 @@ progVersion() {
 
 declare -a files=()
 selected=false
-while [ $# -gt 0 ]; do
+while (($# > 0)); do
   case "$1" in
   -s | --selected)
     selected=true

legacy-bin/cp-svn-url

@@ -68,7 +68,7 @@ done
 # biz logic
 ################################################################################
 
-[ $# -gt 1 ] && {
+(($# > 1)) && {
   echo At most 1 local directory is need!
   usage 1
 }

legacy-bin/svn-merge-stop-on-copy

@@ -37,7 +37,7 @@ EOF
   exit $1
 }
 
-[ $# -gt 2 ] && {
+(($# > 2)) && {
   echo "too many arguments!"
   usage 1
 }

test-cases/bump-scripts-version.sh

@@ -57,7 +57,7 @@ die() {
 # biz logic
 ################################################################################
 
-[ $# -ne 1 ] && die "need only 1 argument for version!$nl${nl}usage:$nl  $0 2.x.y"
+(($# != 1)) && die "need only 1 argument for version!$nl${nl}usage:$nl  $0 2.x.y"
 readonly bump_version=$1
 
 # adjust current dir to project dir

test-cases/my_unit_test_lib.sh

@@ -61,7 +61,7 @@ assertArrayEquals() {
   local a1=("${!a1PlaceHolder}")
   local a2=("${!a2PlaceHolder}")
 
-  [ ${#a1[@]} -eq ${#a2[@]} ] || fail "assertArrayEquals array length [${#a1[@]}] != [${#a2[@]}]${failMsg:+: $failMsg}"
+  ((${#a1[@]} == ${#a2[@]})) || fail "assertArrayEquals array length [${#a1[@]}] != [${#a2[@]}]${failMsg:+: $failMsg}"
 
   local i
   for ((i = 0; i < ${#a1[@]}; i++)); do