[IMP] add tests on ColumnList

Will help ensure future changes won't brake anything.

Part-of: #238
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Author: KangOl

src/base/tests/test_util.py

@@ -839,6 +839,31 @@ def test_create_column_with_fk(self):
         target = util.target_of(cr, "res_partner", "_test_lang_id")
         self.assertEqual(target, ("res_lang", "id", "res_partner__test_lang_id_fkey"))
 
+    def test_ColumnList(self):
+        cr = self.env.cr
+
+        s = lambda c: c.as_string(cr._cnx)
+
+        columns = util.ColumnList(["a", "A"], ['"a"', '"A"'])
+        self.assertEqual(len(columns), 2)
+
+        columns2 = util.ColumnList.from_unquoted(cr, ["a", "A"])
+        self.assertEqual(columns2, columns)
+
+        # iterating it yield quoted columns
+        self.assertEqual(list(iter(columns)), ['"a"', '"A"'])
+
+        self.assertEqual(list(columns.iter_unquoted()), ["a", "A"])
+
+        self.assertEqual(s(columns), '"a", "A"')
+
+        self.assertEqual(s(columns.using(alias="t")), '"t"."a", "t"."A"')
+        self.assertEqual(s(columns.using(leading_comma=True)), ', "a", "A"')
+        self.assertEqual(s(columns.using(trailing_comma=True)), '"a", "A",')
+        self.assertEqual(s(columns.using(leading_comma=True, trailing_comma=True)), ', "a", "A",')
+
+        self.assertIs(columns.using(), columns)
+
 
 class TestORM(UnitTestCase):
     def test_create_cron(self):

src/util/pg.py

@@ -1005,6 +1005,16 @@ def __init__(self, list_=(), quoted=()):
         self._trailing_comma = False
         self._alias = None
 
+    def __eq__(self, other):
+        return (
+            isinstance(other, ColumnList)
+            and other.data == self.data
+            and other._unquoted_columns == self._unquoted_columns
+            and other._leading_comma == self._leading_comma
+            and other._trailing_comma == self._trailing_comma
+            and other._alias == self._alias
+        )
+
     @classmethod
     def from_unquoted(cls, cr, list_):
         """