wip

Author: rrahir

src/util/spreadsheet/fields.py

@@ -52,9 +52,7 @@ def adapter(fun_call):
 
 
 def _rename_field_in_chain(cr, model, field_model, field_chain, old, new) -> str:
-    """
-    model on which the field chain refers to.
-    """
+    """Model on which the field chain refers to."""
     domain = [(field_chain, "=", 1)]
     domain = _adapt_one_domain(cr, field_model, old, new, model, domain)
     if domain is None:
@@ -115,11 +113,10 @@ def _rename_fields(old: str, new: str, fields: Iterable[str]) -> Iterable[str]:
                 renamed.append(new + ":" + aggregate_operator)
             else:
                 renamed.append(field)
+        elif field == old:
+            renamed.append(new)
         else:
-            if field == old:
-                renamed.append(new)
-            else:
-                renamed.append(field)
+            renamed.append(field)
     return renamed
 
 

src/util/spreadsheet/misc.py

@@ -77,6 +77,7 @@ def apply_in_all_spreadsheets(cr, like_pattern, callback):
     for attachment_id, res_model, res_id, db_datas in read_spreadsheet_initial_data(cr, like_pattern):
         revisions_data = []
         revisions_ids = []
+        ## FIXME batch the calls
         for revision_id, commands in get_revisions(cr, res_model, res_id, like_pattern):
             revisions_data.append(json.loads(commands))
             revisions_ids.append(revision_id)