Skip to content

Commit 56a18c1

Browse files
committed
[IMP] create_m2m: use format_query
Use injection-proof `format_query`. Part-of: #304 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
1 parent 5e5b65e commit 56a18c1

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/util/pg.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,16 +1348,23 @@ def create_m2m(cr, m2m, fk1, fk2, col1=None, col2=None):
13481348
fixup_m2m(cr, m2m, fk1, fk2, col1, col2)
13491349
return
13501350

1351-
cr.execute(
1351+
query = format_query(
1352+
cr,
13521353
"""
13531354
CREATE TABLE {m2m}(
13541355
{col1} integer NOT NULL REFERENCES {fk1}(id) ON DELETE CASCADE,
13551356
{col2} integer NOT NULL REFERENCES {fk2}(id) ON DELETE CASCADE,
13561357
PRIMARY KEY ({col1}, {col2})
13571358
);
13581359
CREATE INDEX ON {m2m}({col2}, {col1});
1359-
""".format(**locals())
1360+
""",
1361+
m2m=m2m,
1362+
col1=col1,
1363+
col2=col2,
1364+
fk1=fk1,
1365+
fk2=fk2,
13601366
)
1367+
cr.execute(query)
13611368

13621369

13631370
def update_m2m_tables(cr, old_table, new_table, ignored_m2ms=()):

0 commit comments

Comments
 (0)