fixup

Author: ThanhDodeurOdoo

src/client.ts

@@ -18,7 +18,7 @@ import {
     SERVER_REQUEST,
     WS_CLOSE_CODE
 } from "#src/shared/enums.ts";
-import type { JSONSerializable, StreamType, BusMessage } from "#src/shared/types";
+import type { JSONSerializable, StreamType, BusMessage, AvailableFeatures } from "#src/shared/types";
 import type { TransportConfig, SessionId, SessionInfo } from "#src/models/session";
 
 interface Consumers {
@@ -141,6 +141,10 @@ const ACTIVE_STATES = new Set<SfuClientState>([
 export class SfuClient extends EventTarget {
     /** Connection errors encountered */
     public errors: Error[] = [];
+    public availableFeatures: AvailableFeatures = {
+        "rtc": false,
+        "recording": false,
+    };
     /** Current client state */
     private _state: SfuClientState = SfuClientState.DISCONNECTED;
     /** Communication bus */
@@ -445,7 +449,8 @@ export class SfuClient extends EventTarget {
              */
             webSocket.addEventListener(
                 "message",
-                () => {
+                (message) => {
+                    this.availableFeatures = JSON.parse(message.data) as AvailableFeatures;
                     resolve(new Bus(webSocket));
                 },
                 { once: true }

src/models/channel.ts

@@ -85,12 +85,12 @@ export class Channel extends EventEmitter {
     public readonly key?: Buffer;
     /** mediasoup Router for media routing */
     public readonly router?: Router;
+    /** Manages the recording of this channel, undefined if the feature is disabled */
+    public readonly recorder?: Recorder;
     /** Active sessions in this channel */
     public readonly sessions = new Map<SessionId, Session>();
     /** mediasoup Worker handling this channel */
     private readonly _worker?: RtcWorker;
-    /** Manages the recording of this channel, undefined if the feature is disabled */
-    private recorder?: Recorder;
     /** Timeout for auto-closing empty channels */
     private _closeTimeout?: NodeJS.Timeout;
 

src/models/session.ts

@@ -20,7 +20,7 @@ import {
     SERVER_REQUEST,
     STREAM_TYPE
 } from "#src/shared/enums.ts";
-import type { JSONSerializable, StreamType, BusMessage } from "#src/shared/types";
+import type {JSONSerializable, StreamType, BusMessage, AvailableFeatures } from "#src/shared/types";
 import type { Bus } from "#src/shared/bus.ts";
 import type { Channel } from "#src/models/channel.ts";
 
@@ -167,6 +167,13 @@ export class Session extends EventEmitter {
         this.setMaxListeners(config.CHANNEL_SIZE * 2);
     }
 
+    get availableFeatures(): AvailableFeatures {
+        return {
+            "rtc": Boolean(this._channel.router),
+            "recording": Boolean(this._channel.router && this._channel.recorder && this.permissions.recording)
+        }
+    }
+
     get name(): string {
         return `${this._channel.name}:${this.id}@${this.remote}`;
     }

src/services/auth.ts

@@ -43,7 +43,7 @@ interface PrivateJWTClaims {
     sfu_channel_uuid?: string;
     session_id?: SessionId;
     ice_servers?: object[];
-    permissions: SessionPermissions,
+    permissions?: SessionPermissions,
     sessionIdsByChannel?: Record<string, SessionId[]>;
     /** If provided when requesting a channel, this key will be used instead of the global key to verify JWTs related to this channel */
     key?: string;

src/services/ws.ts

@@ -128,10 +128,12 @@ function connect(webSocket: WebSocket, credentials: Credentials): Session {
     if (!session_id) {
         throw new AuthenticationError("Malformed JWT payload");
     }
-    webSocket.send(""); // client can start using ws after this message.
     const bus = new Bus(webSocket, { batchDelay: config.timeouts.busBatch });
     const { session } = Channel.join(channel.uuid, session_id);
-    session.permissions = permissions;
+    if (permissions) {
+        Object.assign(session.permissions, permissions);
+    }
+    webSocket.send(JSON.stringify(session.availableFeatures)); // client can start using ws after this message.
     session.once("close", ({ code }: { code: string }) => {
         let wsCloseCode = WS_CLOSE_CODE.CLEAN;
         switch (code) {

src/shared/types.ts

@@ -10,6 +10,11 @@ export type StreamType = "audio" | "camera" | "screen";
 
 export type StringLike = Buffer | string;
 
+export type AvailableFeatures = {
+    "rtc": boolean,
+    "recording": boolean,
+}
+
 import type { DownloadStates } from "#src/client.ts";
 import type { SessionId, SessionInfo, TransportConfig } from "#src/models/session.ts";