[WIP] recording: ts version bump, bundle, simpler rec api

Author: ThanhDodeurOdoo

package-lock.json

@@ -30,12 +30,12 @@
     "@jest/globals": "^29.6.2",
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-node-resolve": "^13.0.4",
-    "@rollup/plugin-typescript": "^10.0.1",
+    "@rollup/plugin-typescript": "^12.1.2",
     "@types/jest": "^29.5.0",
-    "@types/node": "^20.5.0",
+    "@types/node": "^22.13.14",
     "@types/ws": "^8.18.1",
-    "@typescript-eslint/eslint-plugin": "8.32.1",
-    "@typescript-eslint/parser": "8.32.1",
+    "@typescript-eslint/eslint-plugin": "^8.46.3",
+    "@typescript-eslint/parser": "^8.46.3",
     "eslint": "8.57.1",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-import": "^2.25.3",
@@ -50,6 +50,6 @@
     "rollup": "^2.79.1",
     "rollup-plugin-license": "3.2.0",
     "ts-jest": "^29.3.4",
-    "typescript": "~5.4.3"
+    "typescript": "~5.9.3"
   }
 }

package.json

@@ -35,9 +35,6 @@ export default {
     plugins: [
         typescript({
             tsconfig: "./tsconfig_bundle.json",
-            declaration: false,
-            declarationMap: false,
-            sourceMap: false,
         }),
         resolve({
             browser: true,

rollup.config.js

@@ -271,7 +271,7 @@ export class SfuClient extends EventTarget {
     }
     async startRecording() {
         if (this.state !== SfuClientState.CONNECTED) {
-            throw new Error("InvalidState");
+            return;
         }
         return this._bus?.request(
             {
@@ -283,7 +283,7 @@ export class SfuClient extends EventTarget {
 
     async stopRecording() {
         if (this.state !== SfuClientState.CONNECTED) {
-            throw new Error("InvalidState");
+            return;
         }
         return this._bus?.request(
             {

src/client.ts

@@ -130,6 +130,8 @@ export class Channel extends EventEmitter {
         logger.info(
             `created channel ${channel.uuid} (${key ? "unique" : "global"} key) for ${safeIssuer}`
         );
+        logger.verbose(`rtc feature: ${Boolean(channel.router)}`);
+        logger.verbose(`recording feature: ${Boolean(channel.recorder)}`);
         const onWorkerDeath = () => {
             logger.warn(`worker died, closing channel ${channel.uuid}`);
             channel.close();

src/models/channel.ts

@@ -32,7 +32,7 @@ export class Recorder extends EventEmitter {
             // TODO ffmpeg instance creation for recording to folder.path with proper name, start, build timestamps object
         }
         this._record();
-        return { state: this.state };
+        return this.isRecording;
     }
 
     async stop() {
@@ -48,7 +48,7 @@ export class Recorder extends EventEmitter {
             // only resolve promise and switch state when completely ready to start a new recording.
             this.state = RECORDER_STATE.STOPPED;
         }
-        return { state: this.state };
+        return this.isRecording;
     }
 
     get isRecording(): boolean {

src/models/recorder.ts

@@ -208,6 +208,7 @@ export class Session extends EventEmitter {
                 continue;
             }
             this.permissions[key] = Boolean(permissions[key]);
+            logger.verbose(`Permissions updated: ${key} = ${this.permissions[key]}`);
         }
     }
 

src/models/session.ts

@@ -43,7 +43,7 @@ interface PrivateJWTClaims {
     sfu_channel_uuid?: string;
     session_id?: SessionId;
     ice_servers?: object[];
-    permissions?: SessionPermissions,
+    permissions?: SessionPermissions;
     sessionIdsByChannel?: Record<string, SessionId[]>;
     /** If provided when requesting a channel, this key will be used instead of the global key to verify JWTs related to this channel */
     key?: string;

src/services/auth.ts

@@ -30,7 +30,7 @@ import type {
     RtpParameters
     // eslint-disable-next-line node/no-unpublished-import
 } from "mediasoup-client/lib/types";
-import type { CLIENT_MESSAGE, CLIENT_REQUEST, SERVER_MESSAGE, SERVER_REQUEST } from "./enums.ts";
+import type { CLIENT_MESSAGE, CLIENT_REQUEST, SERVER_MESSAGE, SERVER_REQUEST } from "./enums";
 
 export type BusMessage =
     | { name: typeof CLIENT_MESSAGE.BROADCAST; payload: JSONSerializable }

src/shared/types.ts

@@ -283,9 +283,9 @@ describe("Full network", () => {
         const sender = await network.connect(channelUUID, 3);
         await Promise.all([user1.isConnected, sender.isConnected]);
         expect(sender.sfuClient.availableFeatures.recording).toBe(true);
-        const startResult = (await sender.sfuClient.startRecording()) as { state: string };
-        expect(startResult.state).toBe("started");
-        const stopResult = (await sender.sfuClient.stopRecording()) as { state: string };
-        expect(stopResult.state).toBe("stopped");
+        const startResult = (await sender.sfuClient.startRecording()) as boolean;
+        expect(startResult).toBe(true);
+        const stopResult = (await sender.sfuClient.stopRecording()) as boolean;
+        expect(stopResult).toBe(false);
     });
 });