[FIX] Selection: Ignore keyboard events when selecting range in the grid #7498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, users can modify the input of a composer/selection input while selecting a range in the grid. Those inputs can have side-effect that are difficult to account for as the selection is managed in a hook which is not aware of the related feature that it handles (selection, cell reference, pivot reference, selection input). A recent work to fix that: #7400 Overall, there is no added value to be able to mix writing text while selecting ranges inside the grid so we simply disable that possibility altogether. Task: 5347297
Collaborator
|
|
robodoo
pushed a commit
that referenced
this pull request
Dec 1, 2025
Currently, users can modify the input of a composer/selection input while selecting a range in the grid. Those inputs can have side-effect that are difficult to account for as the selection is managed in a hook which is not aware of the related feature that it handles (selection, cell reference, pivot reference, selection input). A recent work to fix that: #7400 Overall, there is no added value to be able to mix writing text while selecting ranges inside the grid so we simply disable that possibility altogether. closes #7498 Task: 5347297 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, users can modify the input of a composer/selection input while selecting a range in the grid. Those inputs can have side-effect that are difficult to account for as the selection is managed in a hook which is not aware of the related feature that it handles (selection, cell reference, pivot reference, selection input). A recent work to fix that: #7400
Overall, there is no added value to be able to mix writing text while selecting ranges inside the grid so we simply disable that possibility altogether.
Task: 5347297
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist