[IMP] cleanup

Author: std-odoo

gmail/src/models/lead.ts

@@ -1,5 +1,4 @@
 import { postJsonRpc } from "../utils/http";
-import { isTrue } from "../utils/format";
 import { URLS } from "../const";
 import { getAccessToken } from "src/services/odoo_auth";
 import { _t } from "../services/translation";
@@ -11,10 +10,6 @@ import { Partner } from "./partner";
 export class Lead {
     id: number;
     name: string;
-    expectedRevenue: string;
-    probability: number;
-    recurringRevenue: string;
-    recurringPlan: string;
     revenuesDescription: string;
 
     /**
@@ -58,10 +53,6 @@ export class Lead {
         const lead = new Lead();
         lead.id = values.id;
         lead.name = values.name;
-        lead.expectedRevenue = values.expectedRevenue;
-        lead.probability = values.probability;
-        lead.recurringRevenue = values.recurringRevenue;
-        lead.recurringPlan = values.recurringPlan;
         lead.revenuesDescription = values.revenuesDescription;
         return lead;
     }
@@ -73,33 +64,7 @@ export class Lead {
         const lead = new Lead();
         lead.id = values.id;
         lead.name = values.name;
-        lead.expectedRevenue = values.expected_revenue;
-        lead.probability = values.probability;
-
-        if (isTrue(values.recurring_revenue) && isTrue(values.recurring_plan)) {
-            lead.recurringRevenue = values.recurring_revenue;
-            lead.recurringPlan = values.recurring_plan;
-        }
-        lead.revenuesDescription = this._revenuesDescription(values);
-
+        lead.revenuesDescription = values.revenues_description;
         return lead;
     }
-
-    static _revenuesDescription(values) {
-        if (values.recurringRevenue) {
-            return _t(
-                "%(expected_revenue)s + %(recurring_revenue)s %(recurring_plan)s at %(probability)s%",
-                {
-                    expected_revenue: values.expectedRevenue,
-                    probability: values.probability,
-                    recurring_revenue: values.recurringRevenue,
-                    recurring_plan: values.recurringPlan,
-                },
-            );
-        }
-        return _t("%(expected_revenue)s at %(probability)s%", {
-            expected_revenue: values.expectedRevenue,
-            probability: values.probability,
-        });
-    }
 }

gmail/src/models/state.ts

@@ -1,4 +1,3 @@
-import { isTrue } from "../utils/format";
 import { Email } from "./email";
 import { Partner } from "./partner";
 import { Project } from "./project";
@@ -9,7 +8,7 @@ import { getOdooServerUrl } from "src/services/app_properties";
 /**
  * Object which contains all data for the application.
  *
- * In App-Script, all event handler are function and not method. We can only pass string
+ * In App-Script, all event handlers are function and not method. We can only pass string
  * as arguments. So this object is serialized, then given to the event handler and then
  * unserialize to retrieve the original object.
  *
@@ -91,7 +90,7 @@ export class State {
      */
     static get accessToken() {
         const accessToken = getAccessToken();
-        return isTrue(accessToken);
+        return accessToken?.length && accessToken;
     }
 
     static get isLogged(): boolean {
@@ -103,16 +102,7 @@ export class State {
      */
     static get odooLoginUrl(): string {
         const loginUrl = getOdooAuthUrl();
-        return isTrue(loginUrl);
-    }
-    /**
-     * Return the shared secret between the add-on and IAP
-     * (which is used to authenticate the add-on to IAP).
-     */
-    static get odooSharedSecret(): string {
-        const scriptProperties = PropertiesService.getScriptProperties();
-        const sharedSecret = scriptProperties.getProperty("ODOO_SHARED_SECRET");
-        return isTrue(sharedSecret);
+        return loginUrl?.length && loginUrl;
     }
 
     /**

gmail/src/services/translation.ts

@@ -4,7 +4,7 @@ import { getAccessToken } from "./odoo_auth";
 import { getOdooServerUrl } from "./app_properties";
 
 /**
- * Object which fetchs the translations on the Odoo database, puts them in cache.
+ * Object which fetch the translations on the Odoo database, puts them in cache.
  *
  * Done in a class and not in a simple function so we read only once the cache for all
  * translations.
@@ -32,7 +32,7 @@ export class Translate {
             );
 
             if (this.translations) {
-                // Put in the cacher for 6 hours (maximum cache life time)
+                // Put in the cache for 6 hours (maximum cache lifetime)
                 cache.put(cacheKey, JSON.stringify(this.translations), 21600);
             }
         }

gmail/src/utils/format.ts

@@ -13,36 +13,6 @@ export function formatUrl(url: string): string {
     return url.replace(/\/+$/, "");
 }
 
-/**
- * Return the given string only if it's not null and not empty.
- */
-export function isTrue(value: any): string {
-    if (value && value.length) {
-        return value;
-    }
-}
-
-/**
- * Return the first element of an array if the array is not null and not empty.
- */
-export function first(value: any[]): any {
-    if (value && value.length) {
-        return value[0];
-    }
-}
-
-/**
- * Repeat the given string "n" times.
- */
-export function repeat(str: string, n: number) {
-    let result = "";
-    while (n > 0) {
-        result += str;
-        n--;
-    }
-    return result;
-}
-
 /**
  * Truncate the given text to not exceed the given length.
  */