[FIX] website_sale: product mail action redirect to shop page

Issue:
Mail action redirects only to shop page, even though the user has
internal access to the product page.

To reproduce:
1- Create a db with website_sale installed.
2- Create a product and publish it.
3- In the product page chatter, send a message to an internal user
4- In received email, click on 'View Product' button
5- As you see the shop page opens

This is reproduced after odoo#202555

Inside `_get_access_action`, if the product is published, we are
returning `website_url`. We can add a check to do that only if
user is portal or public.

opw-5155281

closes odoo#233217

X-original-commit: c0f784f
Signed-off-by: Valeriya Chuprina (vchu) <vchu@odoo.com>
Signed-off-by: Mohammadmahdi Alijani (malj) <malj@odoo.com>

Author: mma1377

addons/website_sale/models/product_template.py

@@ -1067,7 +1067,7 @@ def _get_ribbon(self, price_vals=None, auto_assign_ribbons=None, variant=None):
     def _get_access_action(self, access_uid=None, force_website=False):
         """ Instead of the classic form view, redirect to website if it is published. """
         self.ensure_one()
-        if force_website or self.website_published:
+        if force_website or (self.website_published and self.env.user.share):
             return {
                 "type": "ir.actions.act_url",
                 "url": self.website_url,

addons/website_sale/tests/test_mail.py

@@ -4,14 +4,15 @@
 
 import odoo
 from odoo import SUPERUSER_ID, fields
-from odoo.tests import HttpCase, tagged
+from odoo.tests import tagged
 
 from odoo.addons.mail.tests.common import MailCommon
+from odoo.addons.base.tests.common import HttpCaseWithUserPortal
 from odoo.addons.website_sale.tests.common import WebsiteSaleCommon
 
 
 @tagged('post_install', '-at_install', 'mail_thread')
-class TestWebsiteSaleMail(HttpCase):
+class TestWebsiteSaleMail(HttpCaseWithUserPortal):
 
     def test_01_shop_mail_tour(self):
         """The goal of this test is to make sure sending SO by email works."""
@@ -52,6 +53,33 @@ def test_01_shop_mail_tour(self):
             self.assertIn('Your', new_mail.body_html)
             self.assertIn('order', new_mail.body_html)
 
+    def test_shop_product_mail_action_redirection(self):
+        product_template = self.env['product.template'].create({
+            'name': "test product template",
+            'sale_ok': True,
+            'website_published': True,
+        })
+        url = f'/mail/view?model=product.template&res_id={product_template.id}'
+        shop_url = f'/shop/test-product-template-{product_template.id}'
+
+        with self.subTest(user='admin'):
+            self.authenticate('admin', 'admin')
+            res = self.url_open(url)
+            self.assertEqual(res.status_code, 200)
+            self.assertTrue(res.request.path_url.startswith('/odoo/product.template'))
+
+        with self.subTest(user='portal'):
+            self.authenticate('portal', 'portal')
+            res = self.url_open(url)
+            self.assertEqual(res.status_code, 200)
+            self.assertEqual(res.request.path_url, shop_url)
+
+        with self.subTest(user=None):
+            self.authenticate(None, None)
+            res = self.url_open(url)
+            self.assertEqual(res.status_code, 200)
+            self.assertEqual(res.request.path_url, shop_url)
+
 
 @tagged('post_install', '-at_install', 'mail_thread')
 class TestWebsiteSaleMails(MailCommon, WebsiteSaleCommon):