[IMP] im_livechat: refactor _createThread

This commit refactor `_createThread` to use `discuss.channel` and rename
it `_createChannel`

closes odoo#232298

Related: odoo/enterprise#97629
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Author: phenix-factory

addons/im_livechat/static/src/embed/common/attachment_upload_service_patch.js

@@ -5,10 +5,11 @@ import { patch } from "@web/core/utils/patch";
 patch(AttachmentUploadService.prototype, {
     async upload(thread, composer, file, options) {
         if (thread.channel?.channel_type === "livechat" && thread.isTransient) {
-            thread = await this.env.services["im_livechat.livechat"].persist(thread);
-            if (!thread) {
+            const channel = await this.env.services["im_livechat.livechat"].persist(thread);
+            if (!channel) {
                 return;
             }
+            thread = channel.thread;
             thread.readyToSwapDeferred.resolve();
             composer = thread.composer;
         }

addons/im_livechat/static/src/embed/common/livechat_service.js

@@ -54,9 +54,8 @@ export class LivechatService {
      * @returns {Promise<import("models").Thread|undefined>}
      */
     async open(options = {}) {
-        const thread = await this._createThread({ persist: false, options });
-        await thread?.openChatWindow({ focus: true });
-        return thread;
+        const channel = await this._createChannel({ persist: false, options });
+        await channel?.openChatWindow({ focus: true });
     }
 
     /**
@@ -75,25 +74,25 @@ export class LivechatService {
             await this.store.ChatWindow.get({ thread: temporaryThread })?.close({ force: true });
             temporaryThread?.delete();
         };
-        const savedThread = await this._createThread({ originThread: thread, persist: true });
-        if (!savedThread) {
+        const savedChannel = await this._createChannel({ originThread: thread, persist: true });
+        if (!savedChannel) {
             await deleteTemporary();
             return;
         }
-        savedThread.fetchNewMessages();
+        savedChannel.fetchNewMessages();
         this.env.services["mail.store"].initialize();
-        savedThread.readyToSwapDeferred.then(async () => {
-            if (!savedThread?.exists()) {
+        savedChannel.readyToSwapDeferred.then(async () => {
+            if (!savedChannel?.exists()) {
                 return;
             }
             // Do not load unread messaes: new messages were loaded to avoid
             // flickering, we do not want another load that would result in the
             // same issue.
-            savedThread.scrollUnread = false;
+            savedChannel.scrollUnread = false;
             deleteTemporary();
-            savedThread.openChatWindow({ focus: true });
+            savedChannel.openChatWindow({ focus: true });
         });
-        return savedThread;
+        return savedChannel;
     }
 
     /**
@@ -110,7 +109,7 @@ export class LivechatService {
      * @param {import("models").Thread} [param0.originThread]
      * @returns {Promise<import("models").Thread>}
      */
-    async _createThread({ originThread, persist = false, options = {} }) {
+    async _createChannel({ originThread, persist = false, options = {} }) {
         const { store_data, channel_id } = await rpc(
             "/im_livechat/get_session",
             {
@@ -136,7 +135,7 @@ export class LivechatService {
             channel.livechat_operator_id.id,
             ONE_DAY_TTL * 7
         );
-        return channel.thread;
+        return channel;
     }
 
     getSessionExtraParams(thread, options) {

addons/im_livechat/static/src/embed/common/thread_model_patch.js

@@ -118,13 +118,13 @@ patch(Thread.prototype, {
             });
             this.messages.push(temporaryMsg);
             this?.chatbot?._simulateTyping(2 ** 31 - 1);
-            const thread = await this.store.env.services["im_livechat.livechat"].persist(this);
+            const channel = await this.store.env.services["im_livechat.livechat"].persist(this);
             temporaryMsg.author_id = this.store.self; // Might have been created after persist.
-            if (!thread) {
+            if (!channel) {
                 return;
             }
-            await thread.isLoadedDeferred;
-            return thread.post(...arguments).then(() => thread.readyToSwapDeferred.resolve());
+            await channel.isLoadedDeferred;
+            return channel.post(...arguments).then(() => channel.readyToSwapDeferred.resolve());
         }
         const message = await super.post(...arguments);
         await this.chatbot?.processAnswer(message);