[FIX] hr_holidays: Test failing with dynamic dates

test_calendar_event_create_access_rights uses today as the base for the dates
of an holiday request which breaks starting from 17.0 when it generates dates
overlapping a weekend.

This commit makes the test use a static date instead

task-5136270

Author: Megaaaaaa

addons/hr_holidays/tests/test_leave_requests.py

@@ -1658,14 +1658,15 @@ def test_calendar_event_create_access_rights(self):
         self.employee_emp.user_id = user_portal
 
         # As a manager, create a leave request for the employee linked to a portal user
-        leave = self.env['hr.leave'].with_user(self.user_hrmanager_id).create({
-            'name': 'Holiday Request',
-            'employee_id': self.employee_emp_id,
-            'holiday_status_id': self.holidays_type_1.id,
-            'date_from': (datetime.today() - relativedelta(days=1)),
-            'date_to': datetime.today(),
-            'number_of_days': 1,
-        })
+        with freeze_time('2025, 1, 8'):
+            leave = self.env['hr.leave'].with_user(self.user_hrmanager_id).create({
+                'name': 'Holiday Request',
+                'employee_id': self.employee_emp_id,
+                'holiday_status_id': self.holidays_type_1.id,
+                'request_date_from': (datetime.today() - relativedelta(days=7)),
+                'request_date_to': datetime.today(),
+                'number_of_days': 1,
+            })
 
         # Assert the employee cannot approve his own leave request
         with self.assertRaises(AccessError):