Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit e9a4fd1

Browse files
ZyntonZynton
committed
dom helpers: params -> arguments
1 parent bfff55c commit e9a4fd1

File tree

1 file changed

+37
-47
lines changed

1 file changed

+37
-47
lines changed

‎packages/plugin-dom-helpers/src/DomHelpers.ts‎

Lines changed: 37 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
2424
*
2525
* @param params
2626
*/
27-
addClass(params: { domNode: Node | Node[]; class: string | string[] }): void {
28-
const classes = Array.isArray(params.class) ? params.class : [params.class];
29-
for (const node of this.getNodes(params.domNode)) {
27+
addClass(domNode: Node | Node[], className: string | string[]): void {
28+
const classes = Array.isArray(className) ? className : [className];
29+
for (const node of this.getNodes(domNode)) {
3030
node.modifiers.get(Attributes).classList.add(...classes);
3131
}
3232
}
@@ -35,9 +35,9 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
3535
*
3636
* @param params
3737
*/
38-
removeClass(params: { domNode: Node | Node[]; class: string | string[] }): void {
39-
const classes = Array.isArray(params.class) ? params.class : [params.class];
40-
for (const node of this.getNodes(params.domNode)) {
38+
removeClass(domNode: Node | Node[], className: string | string[]): void {
39+
const classes = Array.isArray(className) ? className : [className];
40+
for (const node of this.getNodes(domNode)) {
4141
node.modifiers.get(Attributes).classList.remove(...classes);
4242
}
4343
}
@@ -47,9 +47,9 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
4747
*
4848
* @param params
4949
*/
50-
toggleClass(params: { domNode: Node | Node[]; class: string }): void {
51-
const classes = Array.isArray(params.class) ? params.class : [params.class];
52-
for (const node of this.getNodes(params.domNode)) {
50+
toggleClass(domNode: Node | Node[], className: string): void {
51+
const classes = Array.isArray(className) ? className : [className];
52+
for (const node of this.getNodes(domNode)) {
5353
node.modifiers.get(Attributes).classList.toggle(...classes);
5454
}
5555
}
@@ -58,34 +58,29 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
5858
*
5959
* @param params
6060
*/
61-
setAttribute(params: { domNode: Node | Node[]; name: string; value: string }): void {
62-
for (const node of this.getNodes(params.domNode)) {
63-
node.modifiers.get(Attributes).set(params.name, params.value);
61+
setAttribute(domNode: Node | Node[], name: string, value: string): void {
62+
for (const node of this.getNodes(domNode)) {
63+
node.modifiers.get(Attributes).set(name, value);
6464
}
6565
}
6666
/**
6767
* Set a style key/value pair on a DOM node or a list of DOM nodes.
6868
*
6969
* @param params
7070
*/
71-
setStyle(params: {
72-
domNode: Node | Node[];
73-
name: string;
74-
value: string;
75-
important?: boolean;
76-
}): void {
77-
for (const node of this.getNodes(params.domNode)) {
78-
const value = params.important ? params.value + ' !important' : params.value;
79-
node.modifiers.get(Attributes).style.set(params.name, value);
71+
setStyle(domNode: Node | Node[], name: string, value: string, important?: boolean): void {
72+
for (const node of this.getNodes(domNode)) {
73+
value = important ? value + ' !important' : value;
74+
node.modifiers.get(Attributes).style.set(name, value);
8075
}
8176
}
8277
/**
8378
* Remove a DOM node or a list of DOM nodes.
8479
*
8580
* @param params
8681
*/
87-
remove(params: { domNode: Node | Node[] }): void {
88-
for (const node of this.getNodes(params.domNode)) {
82+
remove(domNode: Node | Node[]): void {
83+
for (const node of this.getNodes(domNode)) {
8984
node.remove();
9085
}
9186
}
@@ -94,8 +89,8 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
9489
*
9590
* @param params
9691
*/
97-
empty(params: { domNode: Node | Node[] }): void {
98-
for (const node of this.getNodes(params.domNode)) {
92+
empty(domNode: Node | Node[]): void {
93+
for (const node of this.getNodes(domNode)) {
9994
node.empty();
10095
}
10196
}
@@ -104,9 +99,9 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
10499
*
105100
* @param params
106101
*/
107-
async replace(params: { domNodes: Node | Node[]; html: string }): Promise<void> {
108-
const nodes = this.getNodes(params.domNodes);
109-
const parsedNodes = await this._parseHtmlString(params.html);
102+
async replace(domNodes: Node | Node[], html: string): Promise<void> {
103+
const nodes = this.getNodes(domNodes);
104+
const parsedNodes = await this._parseHtmlString(html);
110105
const firstNode = nodes[0];
111106
for (const parsedNode of parsedNodes) {
112107
firstNode.before(parsedNode);
@@ -120,14 +115,14 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
120115
*
121116
* @param params
122117
*/
123-
async wrap(params: { domContainer: Node; html: string }): Promise<void> {
124-
const container = this.getNodes(params.domContainer)[0];
118+
async wrap(domContainer: Node, html: string): Promise<void> {
119+
const container = this.getNodes(domContainer)[0];
125120
if (!(container instanceof ContainerNode)) {
126121
throw new Error(
127122
'The provided container must be a ContainerNode in the Jabberwock structure.',
128123
);
129124
}
130-
const parsedNodes = await this._parseHtmlString(params.html);
125+
const parsedNodes = await this._parseHtmlString(html);
131126
for (const parsedNode of parsedNodes) {
132127
container.wrap(parsedNode);
133128
}
@@ -137,9 +132,9 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
137132
*
138133
* @param params
139134
*/
140-
moveBefore(params: { fromDomNode: Node; toDomNode: Node }): void {
141-
const toNode = this.getNodes(params.toDomNode)[0];
142-
for (const fromNode of this.getNodes(params.fromDomNode)) {
135+
moveBefore(fromDomNode: Node, toDomNode: Node): void {
136+
const toNode = this.getNodes(toDomNode)[0];
137+
for (const fromNode of this.getNodes(fromDomNode)) {
143138
fromNode.before(toNode);
144139
}
145140
}
@@ -148,10 +143,10 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
148143
*
149144
* @param params
150145
*/
151-
moveAfter(params: { fromDomNode: Node; toDomNode: Node }): void {
152-
const toNodes = this.getNodes(params.toDomNode);
146+
moveAfter(fromDomNode: Node, toDomNode: Node): void {
147+
const toNodes = this.getNodes(toDomNode);
153148
const toNode = toNodes[toNodes.length - 1];
154-
for (const fromNode of this.getNodes(params.fromDomNode).reverse()) {
149+
for (const fromNode of this.getNodes(fromDomNode).reverse()) {
155150
fromNode.after(toNode);
156151
}
157152
}
@@ -161,22 +156,17 @@ export class DomHelpers<T extends JWPluginConfig = JWPluginConfig> extends JWPlu
161156
*
162157
* @param params
163158
*/
164-
async insertHtml(params: {
165-
html: string;
166-
domNode?: Node;
167-
position?: RelativePosition;
168-
}): Promise<VNode[]> {
159+
async insertHtml(html: string, domNode?: Node, position?: RelativePosition): Promise<VNode[]> {
169160
let nodes: VNode[];
170-
let position: RelativePosition;
171-
if (params.domNode) {
172-
nodes = this.getNodes(params.domNode);
173-
position = params.position || RelativePosition.BEFORE;
161+
if (domNode) {
162+
nodes = this.getNodes(domNode);
163+
position = position || RelativePosition.BEFORE;
174164
} else {
175165
this.editor.selection.range.empty();
176166
nodes = [this.editor.selection.range.start];
177167
position = RelativePosition.BEFORE;
178168
}
179-
const parsedNodes = await this._parseHtmlString(params.html);
169+
const parsedNodes = await this._parseHtmlString(html);
180170
switch (position.toUpperCase()) {
181171
case RelativePosition.BEFORE.toUpperCase():
182172
for (const parsedNode of parsedNodes) {

0 commit comments

Comments
 (0)