Revert "feat: remove previews (#491)" #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb0835b.
nickfloyd
added
the
Type: Maintenance
kfcampbell
approved these changes
Jan 13, 2023
wolfy1339
approved these changes
Jan 13, 2023
Contributor
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 24, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cb0835b.
This reverts #491 because removing the previews logic broke the build for our enterprise modules such as plugin-enterprise-server.js, because of old versions of GHE such as v3.2 and v3.3 (set to be deprecated next week).
Also, because GraaphQL previews are not deprecated yet @octokit/core, @octokit/graphql, and octokit.js will need to be modified.
I missed these things in my review, which is why I am reverting this changeset; so that we can modify the other libraries first and then remove this logic.
Behavior
Before the change?
After the change?
Additional info
Pull request checklist
Does this introduce a breaking change?
Type: Breaking changelabel)If
Yes, what's the impact: