Compiler: use List.compare_length when appropriate

Author: hhugo

compiler/lib/code.ml

@@ -812,7 +812,7 @@ let invariant { blocks; start; _ } =
     let defs = Var.ISet.empty () in
     let check_cont (cont, args) =
       let b = Addr.Map.find cont blocks in
-      assert (List.length args = List.length b.params)
+      assert (List.compare_lengths args b.params = 0)
     in
     let define x =
       if check_defs

compiler/lib/effects.ml

@@ -400,7 +400,7 @@ let allocate_continuation ~st ~alloc_jump_closures ~split_closures src_pc x dire
     &&
     match Hashtbl.find st.is_continuation direct_pc with
     | `Param _ -> true
-    | `Loop -> st.live_vars.(Var.idx x) = List.length args
+    | `Loop -> List.compare_length_with args ~len:st.live_vars.(Var.idx x) = 0
   then alloc_jump_closures, closure_of_pc ~st direct_pc
   else
     let body, branch = cps_branch ~st ~src:src_pc direct_cont in

compiler/lib/generate.ml

@@ -724,7 +724,7 @@ module DTree = struct
     |> List.sort ~cmp:(fun (cont1, _) (cont2, _) -> cont_compare cont1 cont2)
     |> list_group ~equal:cont_equal fst snd
     |> List.map ~f:(fun (cont1, l1) -> cont1, List.flatten l1)
-    |> List.sort ~cmp:(fun (_, l1) (_, l2) -> compare (List.length l1) (List.length l2))
+    |> List.sort ~cmp:(fun (_, l1) (_, l2) -> List.compare_lengths l1 l2)
     |> Array.of_list
 
   let build_if b1 b2 = If (IsTrue, Branch ([ 1 ], b1), Branch ([ 0 ], b2))
@@ -1678,7 +1678,7 @@ and translate_instrs_rev (ctx : Ctx.t) loc expr_queue instrs acc_rev muts_map =
         List.fold_left names ~init:Code.Var.Set.empty ~f:(fun acc name ->
             Code.Var.Set.add name acc)
       in
-      assert (Code.Var.Set.cardinal names = List.length all);
+      assert (List.compare_length_with all ~len:(Code.Var.Set.cardinal names) = 0);
       assert (Code.Var.Set.(is_empty (diff muts fvs)));
       let old_muts_map = muts_map in
       let muts_map_l =

compiler/lib/global_flow.ml

@@ -229,7 +229,7 @@ let expr_deps blocks st x e =
          dependencies right now. This speeds up the analysis
          significantly. *)
       match st.defs.(Var.idx f) with
-      | Expr (Closure (params, _, _)) when List.length args = List.length params ->
+      | Expr (Closure (params, _, _)) when List.compare_lengths args params = 0 ->
           Hashtbl.add st.applied_functions (x, f) ();
           add_to_list st.function_call_sites f x;
           if st.fast
@@ -510,7 +510,7 @@ let propagate st ~update approx x =
                 (fun g ->
                   match st.defs.(Var.idx g) with
                   | Expr (Closure (params, _, _))
-                    when List.length args = List.length params ->
+                    when List.compare_lengths args params = 0 ->
                       if not (Hashtbl.mem st.applied_functions (x, g))
                       then (
                         Hashtbl.add st.applied_functions (x, g) ();
@@ -729,7 +729,7 @@ let exact_call info f n =
       Var.Set.for_all
         (fun g ->
           match info.info_defs.(Var.idx g) with
-          | Expr (Closure (params, _, _)) -> List.length params = n
+          | Expr (Closure (params, _, _)) -> List.compare_length_with params ~len:n = 0
           | Expr (Block _) -> true
           | Expr _ | Phi _ -> assert false)
         known

compiler/lib/source_map.ml

@@ -433,7 +433,7 @@ module Standard = struct
                           let contents =
                             match sm.sources_content with
                             | Some x ->
-                                assert (List.length x = List.length sm.sources);
+                                assert (List.compare_lengths x sm.sources = 0);
                                 x
                             | None -> List.map sm.sources ~f:(fun _ -> None)
                           in
@@ -602,7 +602,7 @@ module Standard = struct
     match sources_content with
     | None -> ()
     | Some x ->
-        if not (List.length sources = List.length x)
+        if List.compare_lengths sources x <> 0
         then
           invalid_arg
             "Source_map.Standard.invariant: sources and sourcesContent must have the \