refactor: . Fix Statuses/StatusRegistryReport.ts > Statuses/StatusSettingsReport.ts cyclic dependency

Author: claremacrae

circular-deps.txt

@@ -1,4 +1,4 @@
-Processed 152 files (1s) (16 warnings)
+Processed 152 files (995ms) (16 warnings)
 
 1) Config/Settings.ts > Suggestor/Suggestor.ts
 2) Task/Task.ts > Config/Settings.ts > Suggestor/Suggestor.ts
@@ -9,8 +9,7 @@ Processed 152 files (1s) (16 warnings)
 7) Task/Task.ts > lib/LogTasksHelper.ts
 8) Query/Query.ts > Query/Explain/Explainer.ts
 9) Query/FilterParser.ts > Query/Filter/BooleanField.ts
-10) Statuses/StatusRegistryReport.ts > Statuses/StatusSettingsReport.ts
-11) main.ts > Config/SettingsTab.ts
-12) Obsidian/Cache.ts > Obsidian/TasksEvents.ts
-13) main.ts > Renderer/QueryRenderer.ts
+10) main.ts > Config/SettingsTab.ts
+11) Obsidian/Cache.ts > Obsidian/TasksEvents.ts
+12) main.ts > Renderer/QueryRenderer.ts
 

src/Statuses/StatusRegistryReport.ts

@@ -47,14 +47,3 @@ ${settingsTable}
 These are the settings actually used by Tasks.
 ${mermaidText}`;
 }
-
-export function getPrintableSymbol(symbol: string) {
-    // Do not put backticks around an empty symbol, as the two backticks are rendered
-    // by Obsidian as ordinary characters and the meaning is unclear.
-    // Better to just display nothing in this situation.
-    if (symbol === '') {
-        return symbol;
-    }
-    const result = symbol !== ' ' ? symbol : 'space';
-    return '`' + result + '`';
-}

src/Statuses/StatusSettingsReport.ts

@@ -1,14 +1,24 @@
 import { StatusSettings } from '../Config/StatusSettings';
 import { MarkdownTable } from '../lib/MarkdownTable';
 import type { StatusConfiguration } from './StatusConfiguration';
-import { getPrintableSymbol } from './StatusRegistryReport';
-import { Status } from './Status';
 import { StatusType } from './StatusConfiguration';
+import { Status } from './Status';
 
 function getFirstIndex(statusConfigurations: StatusConfiguration[], wantedSymbol: string) {
     return statusConfigurations.findIndex((s) => s.symbol === wantedSymbol);
 }
 
+export function getPrintableSymbol(symbol: string) {
+    // Do not put backticks around an empty symbol, as the two backticks are rendered
+    // by Obsidian as ordinary characters and the meaning is unclear.
+    // Better to just display nothing in this situation.
+    if (symbol === '') {
+        return symbol;
+    }
+    const result = symbol !== ' ' ? symbol : 'space';
+    return '`' + result + '`';
+}
+
 function checkIfConventionalType(status: StatusConfiguration, problems: string[]) {
     // Check if conventional type is being used:
     const conventionalType = Status.getTypeForUnknownSymbol(status.symbol);

tests/TestingTools/VerifyStatuses.ts

@@ -1,5 +1,4 @@
 import { verify } from 'approvals/lib/Providers/Jest/JestApprovals';
-import { getPrintableSymbol } from '../../src/Statuses/StatusRegistryReport';
 import type { Status } from '../../src/Statuses/Status';
 import { MarkdownTable } from '../../src/lib/MarkdownTable';
 import type { Task } from '../../src/Task/Task';
@@ -11,6 +10,7 @@ import { StatusField } from '../../src/Query/Filter/StatusField';
 import { StatusTypeField } from '../../src/Query/Filter/StatusTypeField';
 import { StatusNameField } from '../../src/Query/Filter/StatusNameField';
 import { StatusRegistry } from '../../src/Statuses/StatusRegistry';
+import { getPrintableSymbol } from '../../src/Statuses/StatusSettingsReport';
 import { TaskBuilder } from './TaskBuilder';
 import { verifyMarkdownForDocs } from './VerifyMarkdown';
 import { verifyWithFileExtension } from './ApprovalTestHelpers';