Fix charAt and substr of undefined

André Coelho · André Coelho · commit e35acfe3f85a · 2017-04-03T12:17:45.000+01:00
diff --git a/src/providers/oauth-token-provider.js b/src/providers/oauth-token-provider.js
@@ -73,11 +73,14 @@ function OAuthTokenProvider() {
        */
 
       getAuthorizationHeader() {
-        if (!(this.getTokenType() && this.getAccessToken())) {
+        const tokenType = this.getTokenType();
+        const accessToken = this.getAccessToken();
+
+        if (!tokenType || !accessToken) {
           return;
         }
 
-        return `${this.getTokenType().charAt(0).toUpperCase() + this.getTokenType().substr(1)} ${this.getAccessToken()}`;
+        return `${tokenType.charAt(0).toUpperCase() + tokenType.substr(1)} ${accessToken}`;
       }
 
       /**

Original file line number	Diff line number	Diff line change
`@@ -73,11 +73,14 @@ function OAuthTokenProvider() {`
`73`	`73`	`*/`
`74`	`74`
`75`	`75`	`getAuthorizationHeader() {`
`76`		`- if (!(this.getTokenType() && this.getAccessToken())) {`
	`76`	`+ const tokenType = this.getTokenType();`
	`77`	`+ const accessToken = this.getAccessToken();`
	`78`	`+`
	`79`	`+ if (!tokenType \|\| !accessToken) {`
`77`	`80`	`return;`
`78`	`81`	`}`
`79`	`82`
`80`		- return `${this.getTokenType().charAt(0).toUpperCase() + this.getTokenType().substr(1)} ${this.getAccessToken()}`;
	`83`	+ return `${tokenType.charAt(0).toUpperCase() + tokenType.substr(1)} ${accessToken}`;
`81`	`84`	`}`
`82`	`85`
`83`	`86`	`/**`