use Option<&T> instead of &Option<T> (#1338)

* init

* Update src/ui/mod.rs

Co-authored-by: Spenser Black <spenserblack01@gmail.com>

* Update src/ui/mod.rs

Co-authored-by: Spenser Black <spenserblack01@gmail.com>

---------

Co-authored-by: Spenser Black <spenserblack01@gmail.com>

Author: o2sh

src/info/mod.rs

@@ -162,7 +162,7 @@ pub fn build_info(cli_options: &CliOptions) -> Result<Info> {
     };
     let dominant_language = langs::get_main_language(&loc_by_language);
     let ascii_colors = get_ascii_colors(
-        &cli_options.ascii.ascii_language,
+        cli_options.ascii.ascii_language.as_ref(),
         &dominant_language,
         &cli_options.ascii.ascii_colors,
         true_color,
@@ -180,19 +180,19 @@ pub fn build_info(cli_options: &CliOptions) -> Result<Info> {
 
     Ok(InfoBuilder::new(cli_options)
         .title(&repo, no_bold, &text_colors)
-        .project(&repo, &repo_url, &manifest, number_separator)?
-        .description(&manifest)
+        .project(&repo, &repo_url, manifest.as_ref(), number_separator)?
+        .description(manifest.as_ref())
         .head(&repo)?
         .pending(&repo)?
-        .version(&repo, &manifest)?
+        .version(&repo, manifest.as_ref())?
         .created(&git_metrics, iso_time)
         .languages(
             &loc_by_language,
             true_color,
             number_of_languages_to_display,
             &text_colors,
         )
-        .dependencies(&manifest, number_separator)
+        .dependencies(manifest.as_ref(), number_separator)
         .authors(
             &git_metrics,
             number_of_authors_to_display,
@@ -211,7 +211,7 @@ pub fn build_info(cli_options: &CliOptions) -> Result<Info> {
         )?
         .loc(&loc_by_language, number_separator)
         .size(&repo, number_separator)
-        .license(&repo_path, &manifest)?
+        .license(&repo_path, manifest.as_ref())?
         .build(cli_options, text_colors, dominant_language, ascii_colors))
 }
 
@@ -239,9 +239,9 @@ impl InfoBuilder {
         self
     }
 
-    fn description(mut self, manifest: &Option<Manifest>) -> Self {
+    fn description(mut self, manifest: Option<&Manifest>) -> Self {
         if !self.disabled_fields.contains(&InfoType::Description) {
-            let description = DescriptionInfo::new(manifest.as_ref());
+            let description = DescriptionInfo::new(manifest);
             self.info_fields.push(Box::new(description));
         }
         self
@@ -267,11 +267,11 @@ impl InfoBuilder {
         mut self,
         repo: &Repository,
         repo_url: &str,
-        manifest: &Option<Manifest>,
+        manifest: Option<&Manifest>,
         number_separator: NumberSeparator,
     ) -> Result<Self> {
         if !self.disabled_fields.contains(&InfoType::Project) {
-            let project = ProjectInfo::new(repo, repo_url, manifest.as_ref(), number_separator)?;
+            let project = ProjectInfo::new(repo, repo_url, manifest, number_separator)?;
             self.info_fields.push(Box::new(project));
         }
         Ok(self)
@@ -285,9 +285,9 @@ impl InfoBuilder {
         Ok(self)
     }
 
-    fn version(mut self, repo: &Repository, manifest: &Option<Manifest>) -> Result<Self> {
+    fn version(mut self, repo: &Repository, manifest: Option<&Manifest>) -> Result<Self> {
         if !self.disabled_fields.contains(&InfoType::Version) {
-            let version = VersionInfo::new(repo, manifest.as_ref())?;
+            let version = VersionInfo::new(repo, manifest)?;
             self.info_fields.push(Box::new(version));
         }
         Ok(self)
@@ -301,9 +301,9 @@ impl InfoBuilder {
         self
     }
 
-    fn license(mut self, repo_path: &Path, manifest: &Option<Manifest>) -> Result<Self> {
+    fn license(mut self, repo_path: &Path, manifest: Option<&Manifest>) -> Result<Self> {
         if !self.disabled_fields.contains(&InfoType::License) {
-            let license = LicenseInfo::new(repo_path, manifest.as_ref())?;
+            let license = LicenseInfo::new(repo_path, manifest)?;
             self.info_fields.push(Box::new(license));
         }
         Ok(self)
@@ -338,11 +338,11 @@ impl InfoBuilder {
 
     fn dependencies(
         mut self,
-        manifest: &Option<Manifest>,
+        manifest: Option<&Manifest>,
         number_separator: NumberSeparator,
     ) -> Self {
         if !self.disabled_fields.contains(&InfoType::Dependencies) {
-            let dependencies = DependenciesInfo::new(manifest.as_ref(), number_separator);
+            let dependencies = DependenciesInfo::new(manifest, number_separator);
             self.info_fields.push(Box::new(dependencies));
         }
         self

src/ui/mod.rs

@@ -5,7 +5,7 @@ pub mod printer;
 pub mod text_colors;
 
 pub fn get_ascii_colors(
-    ascii_language: &Option<Language>,
+    ascii_language: Option<&Language>,
     dominant_language: &Language,
     ascii_colors: &[u8],
     true_color: bool,
@@ -65,7 +65,7 @@ mod test {
 
     #[test]
     fn get_ascii_colors_no_custom_language_no_custom_colors_no_true_color() {
-        let colors = get_ascii_colors(&None, &Language::Rust, &[], false);
+        let colors = get_ascii_colors(None.as_ref(), &Language::Rust, &[], false);
         assert_eq!(colors.len(), 2);
         assert_eq!(
             colors,
@@ -78,7 +78,7 @@ mod test {
 
     #[test]
     fn get_ascii_colors_no_custom_language_no_custom_colors_true_color() {
-        let colors = get_ascii_colors(&None, &Language::Rust, &[], true);
+        let colors = get_ascii_colors(None, &Language::Rust, &[], true);
         assert_eq!(colors.len(), 2);
         assert_eq!(
             colors,
@@ -88,14 +88,14 @@ mod test {
 
     #[test]
     fn get_ascii_colors_custom_language_no_custom_colors_no_true_color() {
-        let colors = get_ascii_colors(&Some(Language::Sh), &Language::Rust, &[], false);
+        let colors = get_ascii_colors(Some(&Language::Sh), &Language::Rust, &[], false);
         assert_eq!(colors.len(), 1);
         assert_eq!(colors, vec![DynColors::Ansi(AnsiColors::Green)]);
     }
 
     #[test]
     fn get_ascii_colors_no_custom_language_custom_colors_no_true_color() {
-        let colors = get_ascii_colors(&None, &Language::Rust, &[2, 3], false);
+        let colors = get_ascii_colors(None.as_ref(), &Language::Rust, &[2, 3], false);
         assert_eq!(colors.len(), 2);
         assert_eq!(colors, vec![num_to_color(&2), num_to_color(&3)]);
     }
@@ -104,7 +104,7 @@ mod test {
     fn get_ascii_colors_fill_custom_colors_with_language_colors() {
         // When custom ascii colors are not enough for the given language,
         // language colors should be used as default
-        let colors = get_ascii_colors(&None, &Language::Go, &[0], false);
+        let colors = get_ascii_colors(None, &Language::Go, &[0], false);
         assert_eq!(colors.len(), 3);
         assert_eq!(
             colors,