fix(node/p2p): connecting 2 rust nodes failing because rpc channel is being dropped midway

Broke with: 09a9b76#diff-11d338081a1445e76741181b44fb934e652e1bb53e7097178b4d400dc21f7420L124

Author: binier

node/native/src/rpc.rs

@@ -98,10 +98,22 @@ impl node::rpc::RpcService for NodeService {
         respond_p2p_connection_outgoing,
         RpcP2pConnectionOutgoingResponse
     );
-    rpc_service_impl!(
-        respond_p2p_connection_incoming_answer,
-        P2pConnectionResponse
-    );
+
+    fn respond_p2p_connection_incoming_answer(
+        &mut self,
+        rpc_id: RpcId,
+        response: P2pConnectionResponse,
+    ) -> Result<(), RespondError> {
+        let entry = self.rpc.pending.get(rpc_id);
+        let chan = entry.ok_or(RespondError::UnknownRpcId)?;
+        let chan = chan
+            .downcast_ref::<mpsc::Sender<RpcP2pConnectionIncomingResponse>>()
+            .ok_or(RespondError::UnexpectedResponseType)?
+            .clone();
+        chan.try_send(RpcP2pConnectionIncomingResponse::Answer(response))
+            .or(Err(RespondError::RespondingFailed))?;
+        Ok(())
+    }
 
     fn respond_p2p_connection_incoming(
         &mut self,

node/src/rpc/rpc_actions.rs

@@ -262,15 +262,13 @@ pub struct RpcHealthCheckAction {
 
 impl redux::EnablingCondition<crate::State> for RpcHealthCheckAction {}
 
-
 #[derive(Serialize, Deserialize, Debug, Clone)]
 pub struct RpcReadinessCheckAction {
     pub rpc_id: RpcId,
 }
 
 impl redux::EnablingCondition<crate::State> for RpcReadinessCheckAction {}
 
-
 /// Finish/Cleanup rpc request.
 #[derive(Serialize, Deserialize, Debug, Clone)]
 pub struct RpcFinishAction {