fixup: recover lost comments

Author: tizoc

node/src/effects.rs

@@ -48,13 +48,13 @@ pub fn effects<S: Service>(store: &mut Store<S>, action: ActionWithMeta) {
 
             p2p_try_reconnect_disconnected_peers(store);
 
-            store.dispatch(SnarkPoolAction::CheckTimeouts {});
-            store.dispatch(SnarkPoolAction::P2pSendAll {});
+            store.dispatch(SnarkPoolAction::CheckTimeouts);
+            store.dispatch(SnarkPoolAction::P2pSendAll);
 
             p2p_request_best_tip_if_needed(store);
 
-            store.dispatch(SnarkPoolCandidateAction::WorkFetchAll {});
-            store.dispatch(SnarkPoolCandidateAction::WorkVerifyNext {});
+            store.dispatch(SnarkPoolCandidateAction::WorkFetchAll);
+            store.dispatch(SnarkPoolCandidateAction::WorkVerifyNext);
 
             p2p_request_snarks_if_needed(store);
 

node/src/external_snark_worker/external_snark_worker_effects.rs

@@ -27,7 +27,7 @@ pub fn external_snark_worker_effects<S: crate::Service>(
             }
         }
         ExternalSnarkWorkerAction::Started => {
-            store.dispatch(SnarkPoolAction::AutoCreateCommitment {});
+            store.dispatch(SnarkPoolAction::AutoCreateCommitment);
         }
         ExternalSnarkWorkerAction::StartTimeout { .. } => {
             store.dispatch(ExternalSnarkWorkerAction::Error {
@@ -78,6 +78,7 @@ pub fn external_snark_worker_effects<S: crate::Service>(
                 proofs: result.clone(),
             };
             let sender = store.state().p2p.my_id();
+            // Directly add snark to the snark pool as it's produced by us.
             store.dispatch(SnarkPoolAction::WorkAdd { snark, sender });
             store.dispatch(ExternalSnarkWorkerAction::PruneWork);
         }
@@ -100,7 +101,7 @@ pub fn external_snark_worker_effects<S: crate::Service>(
             store.dispatch(ExternalSnarkWorkerAction::PruneWork);
         }
         ExternalSnarkWorkerAction::PruneWork => {
-            store.dispatch(SnarkPoolAction::AutoCreateCommitment {});
+            store.dispatch(SnarkPoolAction::AutoCreateCommitment);
         }
     }
 }

node/src/snark_pool/candidate/snark_pool_candidate_actions.rs

@@ -116,9 +116,11 @@ impl redux::EnablingCondition<crate::State> for SnarkPoolCandidateAction {
                         })
             }
             SnarkPoolCandidateAction::WorkVerifyError { .. } => {
+                // TODO(binier)
                 true
             }
             SnarkPoolCandidateAction::WorkVerifySuccess { .. } => {
+                // TODO(binier)
                 true
             }
             SnarkPoolCandidateAction::PeerPrune { peer_id } => {

node/src/snark_pool/snark_pool_effects.rs

@@ -160,7 +160,7 @@ pub fn snark_pool_effects<S: Service>(store: &mut Store<S>, action: SnarkPoolAct
             }
         }
         SnarkPoolAction::JobCommitmentTimeout { .. } => {
-            store.dispatch(SnarkPoolAction::AutoCreateCommitment {});
+            store.dispatch(SnarkPoolAction::AutoCreateCommitment);
         }
     }
 }

p2p/src/channels/rpc/p2p_channels_rpc_actions.rs

@@ -101,8 +101,11 @@ impl redux::EnablingCondition<P2pState> for P2pChannelsRpcAction {
                 })
             },
             P2pChannelsRpcAction::ResponseReceived { peer_id, id, .. } => {
+                // TODO(binier): use consensus to enforce that peer doesn't send
+                // us inferior block than it has in the past.
                 state.get_ready_peer(peer_id).map_or(false, |p| match &p.channels.rpc {
                     P2pChannelsRpcState::Ready { local, .. } => {
+                        // TODO(binier): validate that response corresponds to request.
                         matches!(local, P2pRpcLocalState::Requested { id: rpc_id, .. } if rpc_id == id)
                     },
                     _ => false,
@@ -120,6 +123,7 @@ impl redux::EnablingCondition<P2pState> for P2pChannelsRpcAction {
             P2pChannelsRpcAction::ResponseSend { peer_id, id, .. } => {
                 state.get_ready_peer(peer_id).map_or(false, |p| match &p.channels.rpc {
                     P2pChannelsRpcState::Ready { remote, .. } => {
+                        // TODO(binier): validate that response corresponds to request.
                         remote.pending_requests.iter().any(|v| v.id == *id)
                     },
                     _ => false,