Rollup merge of rust-lang#114539 - Enselic:unneeded-fixme, r=ehuss

matthiaskrgr · web-flow · commit f542163351c4 · 2023-08-06T17:26:31.000+02:00
linkchecker: Remove unneeded FIXME about intra-doc links It was added by rust-lang#77971 but the adder [proposed](rust-lang#77971 (comment)) that the added code is a good fallback to have in case rustdoc gets buggy, and I agree. So remove the FIXME. This PR is part of rust-lang#44366 which is E-help-wanted. r? `@jyn514` since you added the FIXME `@rustbot` label T-dev-tools
diff --git a/src/tools/linkchecker/main.rs b/src/tools/linkchecker/main.rs
@@ -368,7 +368,6 @@ impl Checker {
             return;
         }
         // Search for intra-doc links that rustdoc didn't warn about
-        // FIXME(#77199, 77200) Rustdoc should just warn about these directly.
         // NOTE: only looks at one line at a time; in practice this should find most links
         for (i, line) in source.lines().enumerate() {
             for broken_link in BROKEN_INTRA_DOC_LINK.captures_iter(line) {

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,6 @@ impl Checker {`
`368`	`368`	`return;`
`369`	`369`	`}`
`370`	`370`	`// Search for intra-doc links that rustdoc didn't warn about`
`371`		`- // FIXME(#77199, 77200) Rustdoc should just warn about these directly.`
`372`	`371`	`// NOTE: only looks at one line at a time; in practice this should find most links`
`373`	`372`	`for (i, line) in source.lines().enumerate() {`
`374`	`373`	`for broken_link in BROKEN_INTRA_DOC_LINK.captures_iter(line) {`