Skip to content

Commit 5ca29cf

Browse files
authored
Merge pull request #25 from nyu-devops/fall23-updates
Updates for the Fall 2023 Semester
2 parents 5cf2629 + 2c088a8 commit 5ca29cf

File tree

7 files changed

+43
-36
lines changed

7 files changed

+43
-36
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM rofrano/nyu-devops-base:su23
1+
FROM rofrano/nyu-devops-base:fa23
22

33
# Add Python package requiremnets to the dev environment
44
WORKDIR /app

.devcontainer/devcontainer.json

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,27 @@
77
"remoteUser": "vscode",
88
"customizations": {
99
"vscode": {
10+
"settings": {
11+
"[python]": {
12+
"editor.defaultFormatter": "ms-python.black-formatter",
13+
"editor.formatOnSave": true
14+
},
15+
"python.linting.enabled": true,
16+
"python.linting.pylintEnabled": true,
17+
"markdown-preview-github-styles.colorTheme": "light",
18+
"files.exclude": {
19+
"**/.git": true,
20+
"**/.DS_Store": true,
21+
"**/*.pyc": true,
22+
"**/__pycache__": true,
23+
"**/.pytest_cache": true
24+
}
25+
},
1026
"extensions": [
1127
"VisualStudioExptTeam.vscodeintellicode",
1228
"ms-python.python",
1329
"ms-python.pylint",
1430
"ms-python.vscode-pylance",
15-
"alexkrechik.cucumberautocomplete",
1631
"cstrap.flask-snippets",
1732
"yzhang.markdown-all-in-one",
1833
"bierner.github-markdown-preview",
@@ -31,7 +46,7 @@
3146
"bbenoist.vagrant"
3247
]
3348
}
34-
},
49+
}
3550
//"forwardPorts": [8000],
3651
// "postCreateCommand": ""
3752
}

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
- name: Run unit tests with green
6565
run: |
6666
export FLASK_APP=service:app
67-
green
67+
pytest --disable-warnings
6868
env:
6969
DATABASE_URI: "postgresql://postgres:pgs3cr3t@postgres:5432/testdb"
7070

.vscode/settings.json

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,13 @@
33
"makefile.extensionOutputFolder": "./.vscode",
44
"git.mergeEditor": true,
55
"python.pythonPath": "/usr/local/bin/python",
6-
"python.linting.enabled": true,
7-
"python.linting.pylintEnabled": true,
8-
"python.testing.pytestEnabled": false,
6+
"python.testing.pytestEnabled": true,
97
"python.testing.unittestEnabled": true,
108
"python.testing.unittestArgs": [
119
"-v",
1210
"-s",
1311
"./tests",
1412
"-p",
1513
"test*.py"
16-
],
17-
"files.exclude": {
18-
"**/.git": true,
19-
"**/.svn": true,
20-
"**/.hg": true,
21-
"**/CVS": true,
22-
"**/.DS_Store": true,
23-
"**/*.pyc": true,
24-
"**/__pycache__": true
25-
}
14+
]
2615
}

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ lint: ## Run the linter
2626

2727
test: ## Run the unit tests
2828
$(info Running tests...)
29-
green -vvv --processes=1 --run-coverage --termcolor --minimum-coverage=95
29+
pytest --disable-warnings
3030

3131
##@ Runtime
3232

requirements.txt

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,29 @@
11
# Pinned dependencies that cause breakage
2-
Werkzeug==2.3.3
2+
Werkzeug==2.3.7
33
SQLAlchemy==2.0.0
44

55
# Runtime dependencies
6-
Flask==2.3.2
6+
Flask==2.3.3
77
Flask-SQLAlchemy==3.0.2
88
psycopg2==2.9.5
9-
python-dotenv==0.21.1
9+
python-dotenv==1.0.0
1010

1111
# Runtime tools
12-
gunicorn==20.1.0
12+
gunicorn==21.2.0
1313
honcho==1.1.0
1414

1515
# Code quality
16-
pylint==2.16.2
17-
flake8==6.0.0
18-
black==23.1.0
16+
pylint==2.17.5
17+
flake8==6.1.0
18+
black==23.7.0
1919

2020
# Testing dependencies
21-
green==3.4.3
22-
factory-boy==3.2.1
23-
coverage==7.1.0
21+
pytest==7.4.0
22+
pytest-pspec==0.0.4
23+
pytest-cov==4.1.0
24+
25+
factory-boy==3.3.0
26+
coverage==7.3.0
2427

2528
# Utilities
26-
httpie==3.2.1
29+
httpie==3.2.2

setup.cfg

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
[green]
2-
verbose=3
3-
processes=1
4-
run-coverage=1
5-
termcolor=1
6-
minimum-coverage=95
7-
junit-report=./unittests.xml
1+
# setup configuration for tools
2+
[tool:pytest]
3+
minversion = 6.0
4+
addopts = --pspec --cov=service --disable-warnings
5+
testpaths =
6+
tests
7+
integration
88

99
[flake8]
1010
max-line-length = 127

0 commit comments

Comments
 (0)