Fix list element index in error messages

Author: Michael Penick

rules.go

@@ -1761,9 +1761,9 @@ func isValidLiteralValue(ttype Input, valueAST ast.Value) (bool, []string) {
 		itemType, _ := ttype.OfType.(Input)
 		if valueAST, ok := valueAST.(*ast.ListValue); ok {
 			messagesReduce := []string{}
-			for _, value := range valueAST.Values {
+			for idx, value := range valueAST.Values {
 				_, messages := isValidLiteralValue(itemType, value)
-				for idx, message := range messages {
+				for _, message := range messages {
 					messagesReduce = append(messagesReduce, fmt.Sprintf(`In element #%v: %v`, idx+1, message))
 				}
 			}

rules_arguments_of_correct_type_test.go

@@ -500,7 +500,7 @@ func TestValidate_ArgValuesOfCorrectType_InvalidListValue_IncorrectItemType(t *t
         `,
 		[]gqlerrors.FormattedError{
 			testutil.RuleError(
-				"Argument \"stringListArg\" has invalid value [\"one\", 2].\nIn element #1: Expected type \"String\", found 2.",
+				"Argument \"stringListArg\" has invalid value [\"one\", 2].\nIn element #2: Expected type \"String\", found 2.",
 				4, 47,
 			),
 		})
@@ -742,7 +742,7 @@ func TestValidate_ArgValuesOfCorrectType_InvalidInputObjectValue_PartialObject_I
         `,
 		[]gqlerrors.FormattedError{
 			testutil.RuleError(
-				"Argument \"complexArg\" has invalid value {stringListField: [\"one\", 2], requiredField: true}.\nIn field \"stringListField\": In element #1: Expected type \"String\", found 2.",
+				"Argument \"complexArg\" has invalid value {stringListField: [\"one\", 2], requiredField: true}.\nIn field \"stringListField\": In element #2: Expected type \"String\", found 2.",
 				4, 41,
 			),
 		})

rules_default_values_of_correct_type_test.go

@@ -97,7 +97,7 @@ func TestValidate_VariableDefaultValuesOfCorrectType_ListVariablesWithInvalidIte
 		[]gqlerrors.FormattedError{
 			testutil.RuleError(
 				`Variable "$a" has invalid default value: ["one", 2].`+
-					"\nIn element #1: Expected type \"String\", found 2.",
+					"\nIn element #2: Expected type \"String\", found 2.",
 				2, 40),
 		})
 }