Skip to content

fix: fix assertion #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: fix assertion #6238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91b9f4c
Fix assertion
YichiZhang0613 Nov 26, 2025
e500517
Fix comment
YichiZhang0613 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nym-node/src/config/gateway_tasks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ impl ZkNymTicketHandlerDebug {
pub const DEFAULT_MINIMUM_API_QUORUM: f32 = 0.7;
pub const DEFAULT_MINIMUM_REDEMPTION_TICKETS: usize = 100;

// use min(4/5 of max validity, validity - 1), but making sure it's no greater than 1 day
// use min(4/5 of max validity, validity - 1), but making sure it's no lower than 1 day
// ASSUMPTION: our validity period is AT LEAST 2 days
//
// this could have been a constant, but it's more readable as a function
Expand All @@ -149,7 +149,7 @@ impl ZkNymTicketHandlerDebug {
};

assert!(
target_secs > 86400,
target_secs >= 86400,
"the maximum time between redemption can't be lower than 1 day!"
);
Duration::from_secs(target_secs as u64)
Expand Down
4 changes: 2 additions & 2 deletions nym-node/src/config/old_configs/old_config_v10.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ impl ZkNymTicketHandlerDebugV10 {
pub const DEFAULT_MINIMUM_API_QUORUM: f32 = 0.8;
pub const DEFAULT_MINIMUM_REDEMPTION_TICKETS: usize = 100;

// use min(4/5 of max validity, validity - 1), but making sure it's no greater than 1 day
// use min(4/5 of max validity, validity - 1), but making sure it's no lower than 1 day
// ASSUMPTION: our validity period is AT LEAST 2 days
//
// this could have been a constant, but it's more readable as a function
Expand All @@ -598,7 +598,7 @@ impl ZkNymTicketHandlerDebugV10 {
};

assert!(
target_secs > 86400,
target_secs >= 86400,
"the maximum time between redemption can't be lower than 1 day!"
);
Duration::from_secs(target_secs as u64)
Expand Down
4 changes: 2 additions & 2 deletions nym-node/src/config/old_configs/old_config_v4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ impl ZkNymTicketHandlerDebugV4 {
pub const DEFAULT_MINIMUM_API_QUORUM: f32 = 0.8;
pub const DEFAULT_MINIMUM_REDEMPTION_TICKETS: usize = 100;

// use min(4/5 of max validity, validity - 1), but making sure it's no greater than 1 day
// use min(4/5 of max validity, validity - 1), but making sure it's no lower than 1 day
// ASSUMPTION: our validity period is AT LEAST 2 days
//
// this could have been a constant, but it's more readable as a function
Expand All @@ -436,7 +436,7 @@ impl ZkNymTicketHandlerDebugV4 {
};

assert!(
target_secs > 86400,
target_secs >= 86400,
"the maximum time between redemption can't be lower than 1 day!"
);
Duration::from_secs(target_secs as u64)
Expand Down
4 changes: 2 additions & 2 deletions nym-node/src/config/old_configs/old_config_v5.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ impl ZkNymTicketHandlerDebugV5 {
pub const DEFAULT_MINIMUM_API_QUORUM: f32 = 0.8;
pub const DEFAULT_MINIMUM_REDEMPTION_TICKETS: usize = 100;

// use min(4/5 of max validity, validity - 1), but making sure it's no greater than 1 day
// use min(4/5 of max validity, validity - 1), but making sure it's no lower than 1 day
// ASSUMPTION: our validity period is AT LEAST 2 days
//
// this could have been a constant, but it's more readable as a function
Expand All @@ -438,7 +438,7 @@ impl ZkNymTicketHandlerDebugV5 {
};

assert!(
target_secs > 86400,
target_secs >= 86400,
"the maximum time between redemption can't be lower than 1 day!"
);
Duration::from_secs(target_secs as u64)
Expand Down
4 changes: 2 additions & 2 deletions nym-node/src/config/old_configs/old_config_v6.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ impl ZkNymTicketHandlerDebugV6 {
pub const DEFAULT_MINIMUM_API_QUORUM: f32 = 0.8;
pub const DEFAULT_MINIMUM_REDEMPTION_TICKETS: usize = 100;

// use min(4/5 of max validity, validity - 1), but making sure it's no greater than 1 day
// use min(4/5 of max validity, validity - 1), but making sure it's no lower than 1 day
// ASSUMPTION: our validity period is AT LEAST 2 days
//
// this could have been a constant, but it's more readable as a function
Expand All @@ -458,7 +458,7 @@ impl ZkNymTicketHandlerDebugV6 {
};

assert!(
target_secs > 86400,
target_secs >= 86400,
"the maximum time between redemption can't be lower than 1 day!"
);
Duration::from_secs(target_secs as u64)
Expand Down
4 changes: 2 additions & 2 deletions nym-node/src/config/old_configs/old_config_v7.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ impl ZkNymTicketHandlerDebugV7 {
pub const DEFAULT_MINIMUM_API_QUORUM: f32 = 0.8;
pub const DEFAULT_MINIMUM_REDEMPTION_TICKETS: usize = 100;

// use min(4/5 of max validity, validity - 1), but making sure it's no greater than 1 day
// use min(4/5 of max validity, validity - 1), but making sure it's no lower than 1 day
// ASSUMPTION: our validity period is AT LEAST 2 days
//
// this could have been a constant, but it's more readable as a function
Expand All @@ -516,7 +516,7 @@ impl ZkNymTicketHandlerDebugV7 {
};

assert!(
target_secs > 86400,
target_secs >= 86400,
"the maximum time between redemption can't be lower than 1 day!"
);
Duration::from_secs(target_secs as u64)
Expand Down
4 changes: 2 additions & 2 deletions nym-node/src/config/old_configs/old_config_v8.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ impl ZkNymTicketHandlerDebugV8 {
pub const DEFAULT_MINIMUM_API_QUORUM: f32 = 0.8;
pub const DEFAULT_MINIMUM_REDEMPTION_TICKETS: usize = 100;

// use min(4/5 of max validity, validity - 1), but making sure it's no greater than 1 day
// use min(4/5 of max validity, validity - 1), but making sure it's no lower than 1 day
// ASSUMPTION: our validity period is AT LEAST 2 days
//
// this could have been a constant, but it's more readable as a function
Expand All @@ -490,7 +490,7 @@ impl ZkNymTicketHandlerDebugV8 {
};

assert!(
target_secs > 86400,
target_secs >= 86400,
"the maximum time between redemption can't be lower than 1 day!"
);
Duration::from_secs(target_secs as u64)
Expand Down
4 changes: 2 additions & 2 deletions nym-node/src/config/old_configs/old_config_v9.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ impl ZkNymTicketHandlerDebugV9 {
pub const DEFAULT_MINIMUM_API_QUORUM: f32 = 0.8;
pub const DEFAULT_MINIMUM_REDEMPTION_TICKETS: usize = 100;

// use min(4/5 of max validity, validity - 1), but making sure it's no greater than 1 day
// use min(4/5 of max validity, validity - 1), but making sure it's no lower than 1 day
// ASSUMPTION: our validity period is AT LEAST 2 days
//
// this could have been a constant, but it's more readable as a function
Expand All @@ -591,7 +591,7 @@ impl ZkNymTicketHandlerDebugV9 {
};

assert!(
target_secs > 86400,
target_secs >= 86400,
"the maximum time between redemption can't be lower than 1 day!"
);
Duration::from_secs(target_secs as u64)
Expand Down