clippy

mfahampshire · mfahampshire · commit f23114d654f4 · 2025-10-20T22:41:55.000+01:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -115,7 +115,7 @@ members = [
     "common/wireguard-private-metadata/tests",
     "common/wireguard-types",
     "common/zulip-client",
-    "documentation/autodoc",
+    # "documentation/autodoc",
     "gateway",
     "nym-api",
     "nym-api/nym-api-requests",
diff --git a/common/client-core/src/client/base_client/mod.rs b/common/client-core/src/client/base_client/mod.rs
@@ -68,7 +68,6 @@ use std::path::Path;
 use std::sync::Arc;
 use time::OffsetDateTime;
 use tokio_util::sync::{PollSendError, PollSender};
-use tracing::{debug, error, info};
 use url::Url;
 
 #[cfg(target_arch = "wasm32")]
diff --git a/common/client-core/src/client/inbound_messages.rs b/common/client-core/src/client/inbound_messages.rs
@@ -214,7 +214,7 @@ impl Encoder<&[u8]> for AdressedInputMessageCodec {
 
     fn encode(&mut self, item: &[u8], buf: &mut BytesMut) -> Result<(), Self::Error> {
         let mut codec = InputMessageCodec;
-        let input_message = InputMessage::simple(item, self.0.clone());
+        let input_message = InputMessage::simple(item, self.0);
         codec.encode(input_message, buf)?;
         Ok(())
     }
diff --git a/common/client-core/src/lib.rs b/common/client-core/src/lib.rs
@@ -1,3 +1,4 @@
+#![allow(deprecated)]
 use std::future::Future;
 
 #[cfg(all(
diff --git a/common/client-core/surb-storage/src/lib.rs b/common/client-core/surb-storage/src/lib.rs
@@ -1,6 +1,7 @@
 // Copyright 2022 - Nym Technologies SA <contact@nymtech.net>
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(deprecated)]
 pub use backend::*;
 pub use combined::CombinedReplyStorage;
 pub use key_storage::SentReplyKeys;
diff --git a/common/cosmwasm-smart-contracts/coconut-dkg/src/types.rs b/common/cosmwasm-smart-contracts/coconut-dkg/src/types.rs
@@ -1,6 +1,8 @@
 // Copyright 2022-2023 - Nym Technologies SA <contact@nymtech.net>
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(clippy::derivable_impls)]
+// MAX: surpressing warning for the moment, will be dealt with in a different PR (TODO)
 use cosmwasm_schema::cw_serde;
 use std::fmt::{Display, Formatter};
 use std::str::FromStr;
diff --git a/common/credential-storage/src/ephemeral_storage.rs b/common/credential-storage/src/ephemeral_storage.rs
@@ -246,7 +246,7 @@ mod tests {
         let _exp_date_sigs = generate_expiration_date_signatures(
             sig_req.expiration_date.ecash_unix_timestamp(),
             &[signing_keys.secret_key()],
-            &vec![signing_keys.verification_key()],
+            &[signing_keys.verification_key()],
             &signing_keys.verification_key(),
             &[1],
         )?;
@@ -263,7 +263,7 @@ mod tests {
 
         let wallet = issuance.aggregate_signature_shares(
             &signing_keys.verification_key(),
-            &vec![partial_wallet],
+            &[partial_wallet],
             sig_req,
         )?;
 
diff --git a/common/crypto/src/lib.rs b/common/crypto/src/lib.rs
@@ -1,6 +1,9 @@
 // Copyright 2021 - Nym Technologies SA <contact@nymtech.net>
 // SPDX-License-Identifier: Apache-2.0
 
+// MAX: temp ignore deprecated, can be dealt with in its own PR (TODO)
+#![allow(deprecated)]
+
 #[cfg(feature = "asymmetric")]
 pub mod asymmetric;
 pub mod bech32_address_validation;
diff --git a/common/gateway-requests/src/lib.rs b/common/gateway-requests/src/lib.rs
@@ -1,5 +1,6 @@
 // Copyright 2020-2022 - Nym Technologies SA <contact@nymtech.net>
 // SPDX-License-Identifier: Apache-2.0
+#![allow(deprecated)]
 
 pub use nym_crypto::generic_array;
 use nym_crypto::OutputSizeUser;
diff --git a/common/gateway-requests/src/models.rs b/common/gateway-requests/src/models.rs
@@ -82,7 +82,7 @@ mod tests {
         let exp_date_sigs = generate_expiration_date_signatures(
             sig_req.expiration_date.ecash_unix_timestamp(),
             &[keypair.secret_key()],
-            &vec![keypair.verification_key()],
+            &[keypair.verification_key()],
             &keypair.verification_key(),
             &[keypair.index.unwrap()],
         )
@@ -106,14 +106,14 @@ mod tests {
             .unwrap();
 
         let wallet = issuance
-            .aggregate_signature_shares(&keypair.verification_key(), &vec![partial_wallet], sig_req)
+            .aggregate_signature_shares(&keypair.verification_key(), &[partial_wallet], sig_req)
             .unwrap();
 
         let mut issued = issuance.into_issued_ticketbook(wallet, 1);
         let coin_indices_signatures = generate_coin_indices_signatures(
             nym_credentials_interface::ecash_parameters(),
             &[keypair.secret_key()],
-            &vec![keypair.verification_key()],
+            &[keypair.verification_key()],
             &keypair.verification_key(),
             &[keypair.index.unwrap()],
         )
diff --git a/common/http-api-client/src/lib.rs b/common/http-api-client/src/lib.rs
@@ -1,6 +1,9 @@
 // Copyright 2023 - Nym Technologies SA <contact@nymtech.net>
 // SPDX-License-Identifier: Apache-2.0
 
+// MAX: temp ignore deprecated, can be dealt with in its own PR (TODO)
+#![allow(deprecated)]
+
 //! Nym HTTP API Client
 //!
 //! Centralizes and implements the core API client functionality. This crate provides custom,
@@ -92,7 +95,7 @@
 //!         pub status: ApiStatus,
 //!         pub uptime: u64,
 //!     }
-//!     
+//!
 //!     #[derive(Clone, Copy, Debug, Serialize, Deserialize)]
 //!     pub enum ApiStatus {
 //!         Up,
diff --git a/common/nymsphinx/acknowledgements/src/lib.rs b/common/nymsphinx/acknowledgements/src/lib.rs
@@ -1,5 +1,6 @@
 // Copyright 2021 - Nym Technologies SA <contact@nymtech.net>
 // SPDX-License-Identifier: Apache-2.0
+#![allow(deprecated)]
 
 pub mod identifier;
 pub mod key;
diff --git a/common/nymsphinx/anonymous-replies/src/lib.rs b/common/nymsphinx/anonymous-replies/src/lib.rs
@@ -1,6 +1,7 @@
 // Copyright 2021 - Nym Technologies SA <contact@nymtech.net>
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(deprecated)]
 pub mod encryption_key;
 pub mod reply_surb;
 pub mod requests;
diff --git a/common/store-cipher/src/lib.rs b/common/store-cipher/src/lib.rs
@@ -1,6 +1,7 @@
 // Copyright 2023 - Nym Technologies SA <contact@nymtech.net>
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(deprecated)]
 use aes_gcm::aead::{Aead, Nonce};
 use aes_gcm::{AeadCore, AeadInPlace, KeyInit};
 use rand::{thread_rng, CryptoRng, Fill, RngCore};
diff --git a/nym-api/src/unstable_routes/v1/account/models.rs b/nym-api/src/unstable_routes/v1/account/models.rs
@@ -4,7 +4,6 @@
 use cosmwasm_std::{Addr, Coin};
 use nym_topology::NodeId;
 use serde::{Deserialize, Serialize};
-use utoipa::schema;
 
 #[derive(Clone, Debug, Serialize, Deserialize, utoipa::ToSchema, utoipa::ToResponse)]
 #[schema(title = "Coin")]
diff --git a/nym-outfox/src/lib.rs b/nym-outfox/src/lib.rs
@@ -1,3 +1,6 @@
+// MAX: temp ignore deprecated, can be dealt with in its own PR
+#![allow(deprecated)]
+
 pub mod constants;
 pub mod error;
 pub mod format;

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ impl Encoder<&[u8]> for AdressedInputMessageCodec {`
`214`	`214`
`215`	`215`	`fn encode(&mut self, item: &[u8], buf: &mut BytesMut) -> Result<(), Self::Error> {`
`216`	`216`	`let mut codec = InputMessageCodec;`
`217`		`- let input_message = InputMessage::simple(item, self.0.clone());`
	`217`	`+ let input_message = InputMessage::simple(item, self.0);`
`218`	`218`	`codec.encode(input_message, buf)?;`
`219`	`219`	`Ok(())`
`220`	`220`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#![allow(deprecated)]`
`1`	`2`	`use std::future::Future;`
`2`	`3`
`3`	`4`	`#[cfg(all(`