chore(nxext): update Nx 18.3

Author: DominikPieper

.github/workflows/ci.yml

@@ -3,27 +3,39 @@ name: CI
 on:
   push:
     branches:
-      - main
+      - master
   pull_request:
 
+permissions:
+  actions: read
+  contents: read
+
 jobs:
   main:
-    name: Nx Cloud - Main Job
-    uses: nrwl/ci/.github/workflows/nx-cloud-main.yml@v0.13.0
-    with:
-      main-branch-name: main
-      number-of-agents: 3
-      init-commands: |
-        pnpm exec nx-cloud start-ci-run --stop-agents-after="build" --agent-count=3
-      parallel-commands: |
-        pnpm exec nx-cloud record -- pnpm exec nx format:check
-      parallel-commands-on-agents: |
-        pnpm exec nx affected --target=lint --parallel=3
-        pnpm exec nx affected --target=test --parallel=3 --ci --code-coverage
-        pnpm exec nx affected --target=build --parallel=3
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - uses: pnpm/action-setup@v2
+        with:
+          version: 8
+      # Cache node_modules
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+          cache: 'pnpm'
+      - uses: actions/cache@v4
+        with:
+          lookup-only: true
+          path: '**/node_modules'
+          key: pnpm-${{ hashFiles('pnpm-lock.yaml') }}
+      # Connect your workspace on nx.app and uncomment this to enable task distribution.
+      # The "--stop-agents-after" is optional, but allows idle agents to shut down once the "build" targets have been requested
+      - run: pnpm install --no-frozen-lockfile
+      - uses: nrwl/nx-set-shas@v4
+      #- run: pnpm exec nx-cloud start-ci-run --distribute-on="5 linux-medium-js" --stop-agents-after="build"
 
-  agents:
-    name: Nx Cloud - Agents
-    uses: nrwl/ci/.github/workflows/nx-cloud-agents.yml@v0.13.0
-    with:
-      number-of-agents: 3
+      - run: pnpm exec nx-cloud record -- nx format:check
+      - run: pnpm exec nx affected -t lint test build

.prettierignore

@@ -6,4 +6,5 @@
 .docusaurus/
 /build
 
-/.nx/cache
+/.nx/cache
+pnpm-lock.yaml

package.json

@@ -1,5 +1,5 @@
 {
-  "name": "nxext",
+  "name": "nxext-ionic",
   "version": "0.0.0",
   "license": "MIT",
   "keywords": [
@@ -49,35 +49,34 @@
   "private": true,
   "packageManager": "pnpm@8.7.0",
   "devDependencies": {
-    "@angular-devkit/core": "17.2.1",
-    "@angular-devkit/schematics": "17.2.1",
+    "@angular-devkit/core": "17.3.5",
+    "@angular-devkit/schematics": "17.3.4",
     "@eslint/eslintrc": "^2.1.1",
     "@eslint/js": "8.49.0",
     "@nuxt/kit": "3.10.3",
-    "@nx/angular": "18.2.4",
-    "@nx/cypress": "18.2.4",
-    "@nx/devkit": "18.2.4",
-    "@nx/eslint": "18.2.4",
-    "@nx/eslint-plugin": "18.2.4",
-    "@nx/jest": "18.2.4",
-    "@nx/js": "18.2.4",
-    "@nx/node": "18.2.4",
-    "@nx/playwright": "18.2.4",
-    "@nx/plugin": "18.2.4",
-    "@nx/react": "18.2.4",
-    "@nx/storybook": "18.2.4",
-    "@nx/vite": "18.2.4",
-    "@nx/web": "18.2.4",
-    "@nx/workspace": "18.2.4",
-    "@nxext/svelte": "^17.0.1",
+    "@nx/angular": "18.3.1",
+    "@nx/cypress": "18.3.1",
+    "@nx/devkit": "18.3.1",
+    "@nx/eslint": "18.3.1",
+    "@nx/eslint-plugin": "18.3.1",
+    "@nx/jest": "18.3.1",
+    "@nx/js": "18.3.1",
+    "@nx/node": "18.3.1",
+    "@nx/playwright": "18.3.1",
+    "@nx/plugin": "18.3.1",
+    "@nx/react": "18.3.1",
+    "@nx/storybook": "18.3.1",
+    "@nx/vite": "18.3.1",
+    "@nx/web": "18.3.1",
+    "@nx/workspace": "18.3.1",
+    "@nxext/svelte": "^18.0.0",
     "@phenomnomnominal/tsquery": "~5.0.1",
-    "@schematics/angular": "17.2.1",
+    "@schematics/angular": "17.3.4",
     "@stencil/core": "3.4.0",
     "@swc-node/register": "1.8.0",
     "@swc/cli": "0.1.62",
-    "@swc/core": "1.3.91",
-    "@swc/helpers": "0.5.2",
-    "@swc/jest": "0.2.26",
+    "@swc/core": "^1.3.85",
+    "@swc/jest": "^0.2.20",
     "@types/glob": "^8.1.0",
     "@types/globrex": "^0.1.2",
     "@types/is-ci": "^3.0.1",
@@ -108,7 +107,8 @@
     "jsonc-parser": "^3.2.1",
     "kill-port": "^2.0.1",
     "lint-staged": "13.2.3",
-    "nx": "18.2.4",
+    "nx": "18.3.1",
+    "nx-cloud": "^18.0.0",
     "prettier": "2.7.1",
     "pretty-quick": "^3.1.3",
     "tcp-port-used": "^1.0.2",

packages/capacitor/package.json

@@ -22,12 +22,11 @@
   "schematics": "./generators.json",
   "builders": "./executors.json",
   "dependencies": {
-    "tslib": "^2.3.0",
-    "ignore": "^5.2.4",
-    "@nx/devkit": "18.2.4",
-    "nx": "18.2.4"
+    "@nx/devkit": "18.3.1",
+    "nx": "18.3.1",
+    "@nx/web": "18.3.1",
+    "ignore": "^5.3.1",
+    "tslib": "^2.3.0"
   },
-  "peerDependencies": {
-    "@nx/web": "18.2.4"
-  }
+  "peerDependencies": {}
 }

packages/ionic-angular/package.json

@@ -25,15 +25,14 @@
   "schematics": "./generators.json",
   "builders": "./executors.json",
   "dependencies": {
-    "tslib": "^2.3.0",
     "@nxext/capacitor": "^18.0.4",
+    "@nx/devkit": "18.3.1",
+    "@nx/eslint": "18.3.1",
+    "@nx/angular": "18.3.1",
+    "@nx/js": "18.3.1",
     "@phenomnomnominal/tsquery": "~5.0.1",
-    "@nx/devkit": "18.2.4",
     "typescript": "5.4.5",
-    "@nx/js": "18.2.4"
+    "tslib": "^2.3.0"
   },
-  "peerDependencies": {
-    "@nx/angular": "18.2.4",
-    "@nx/eslint": "18.2.4"
-  }
+  "peerDependencies": {}
 }

packages/ionic-angular/src/generators/application/lib/add-angular.ts

@@ -11,7 +11,8 @@ export async function addAngular(
   return await applicationGenerator(host, {
     ...options,
     name: options.name,
-    skipFormat: options.skipFormat,
+    directory: options.directory,
+    skipFormat: true,
     routing: true,
     style: 'scss',
     linter: Linter.EsLint,

packages/ionic-react/package.json

@@ -25,14 +25,13 @@
   "schematics": "./generators.json",
   "builders": "./executors.json",
   "dependencies": {
-    "tslib": "^2.3.0",
     "@nxext/capacitor": "^18.0.4",
-    "@nx/devkit": "18.2.4",
-    "typescript": "5.4.5"
-  },
-  "peerDependencies": {
-    "@nx/react": "18.2.4",
+    "@nx/devkit": "18.3.1",
+    "@nx/eslint": "18.3.1",
+    "@nx/react": "18.3.1",
+    "typescript": "5.4.5",
     "@phenomnomnominal/tsquery": "~5.0.1",
-    "@nx/eslint": "18.2.4"
-  }
+    "tslib": "^2.3.0"
+  },
+  "peerDependencies": {}
 }