better comment + getattr

Author: SwayamInSync

quaddtype/numpy_quaddtype/src/casts.cpp

@@ -502,8 +502,9 @@ template <>
 inline npy_byte
 from_quad<npy_byte>(quad_value x, QuadBackendType backend)
 {
-    // reduction ops often give warning, we can handle the NAN casting
-    // this behaviour might apply to all casting
+    // runtime warnings often comes from/to casting of NaN, inf
+    // casting is used by ops at several positions leading to warnings
+    // fix can be catching the cases and returning corresponding type value without casting
     if (backend == BACKEND_SLEEF) {
         return (npy_byte)Sleef_cast_to_int64q1(x.sleef_value);
     }

quaddtype/tests/test_quaddtype.py

@@ -411,12 +411,9 @@ def test_reduction_ops(self, op, input_array):
         """Test all and any reduction operations."""
         quad_array = np.array([QuadPrecision(x) for x in input_array])
         float_array = np.array([float(x) for x in input_array])
-        if op == "all":
-            result = np.all(quad_array)
-            expected = np.all(float_array)
-        else:  # op == "any"
-            result = np.any(quad_array)
-            expected = np.any(float_array)
+        op = getattr(np, op)
+        result = op(quad_array)
+        expected = op(float_array)
 
         assert result == expected, (
             f"Reduction op '{op}' failed for input {input_array}: "