Skip to content

Commit 1cf98b8

Browse files
committed
use absolute in fabs
1 parent 238ce35 commit 1cf98b8

File tree

3 files changed

+1
-20
lines changed

3 files changed

+1
-20
lines changed

quaddtype/numpy_quaddtype/src/ops.hpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,6 @@ quad_absolute(const Sleef_quad *op)
3737
return Sleef_fabsq1(*op);
3838
}
3939

40-
static inline Sleef_quad
41-
quad_fabs(const Sleef_quad *op)
42-
{
43-
return Sleef_fabsq1(*op);
44-
}
45-
4640
static inline Sleef_quad
4741
quad_rint(const Sleef_quad *op)
4842
{
@@ -223,12 +217,6 @@ ld_absolute(const long double *op)
223217
return fabsl(*op);
224218
}
225219

226-
static inline long double
227-
ld_fabs(const long double *op)
228-
{
229-
return fabsl(*op);
230-
}
231-
232220
static inline long double
233221
ld_sign(const long double *op)
234222
{

quaddtype/numpy_quaddtype/src/umath/unary_ops.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ init_quad_unary_ops(PyObject *numpy)
156156
if (create_quad_unary_ufunc<quad_absolute, ld_absolute>(numpy, "absolute") < 0) {
157157
return -1;
158158
}
159-
if (create_quad_unary_ufunc<quad_fabs, ld_fabs>(numpy, "fabs") < 0) {
159+
if (create_quad_unary_ufunc<quad_absolute, ld_absolute>(numpy, "fabs") < 0) {
160160
return -1;
161161
}
162162
if (create_quad_unary_ufunc<quad_sign, ld_sign>(numpy, "sign") < 0) {

quaddtype/tests/test_quaddtype.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1388,10 +1388,3 @@ def test_fabs(val):
13881388
if float_result == 0.0:
13891389
assert not np.signbit(quad_result), f"fabs({val}) should not have negative sign"
13901390
assert not np.signbit(quad_arr_result[0]), f"fabs({val}) should not have negative sign"
1391-
1392-
# Verify that fabs and absolute give the same result for QuadPrecision
1393-
quad_absolute_result = np.absolute(quad_val)
1394-
np.testing.assert_array_equal(
1395-
np.array(quad_result).astype(float),
1396-
np.array(quad_absolute_result).astype(float)
1397-
)

0 commit comments

Comments
 (0)