Merge pull request #2339 from numbersprotocol/fix-delete-capture-error

fix(media-store): only ignore File Not Exist error

Author: bafu

src/app/shared/media/media-store/media-store.service.ts

@@ -127,10 +127,25 @@ export class MediaStore {
     await this.deleteThumbnail(index);
     return this.mutex.runExclusive(async () => {
       const extension = await this.getExtension(index);
-      await this.filesystemPlugin.deleteFile({
-        directory: this.directory,
-        path: `${this.rootDir}/${index}.${extension}`,
-      });
+      try {
+        await this.filesystemPlugin.deleteFile({
+          directory: this.directory,
+          path: `${this.rootDir}/${index}.${extension}`,
+        });
+      } catch (error: any) {
+        /* WORKAROUND
+         * In capture app we get "File does not exist error"
+         * if currentPlatform.isAndroid() === true &&
+         *    fileToBeDeleted.isCapturedFromIphone() === true
+         * When we delete capture from iPhone that was captured
+         * by Android "File does not exists" is not thrown.
+         * So we can silently ignore "File does not exist" error
+         * while deleting capture from FileSystem only.
+         */
+        if (error.message !== 'File does not exist') {
+          throw error;
+        }
+      }
       await this.deleteMediaExtension(index);
       return index;
     });