Merge pull request #1409 from numbersprotocol/develop

Bump version to 0.51.1

Author: ruizehung

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.51.1 - 2022-03-23
+
+### Fixed
+
+- Prevent race condition when creating network action history record.
+
 ## 0.51.0 - 2022-03-22
 
 ### Added

android/app/build.gradle

@@ -6,8 +6,8 @@ android {
         applicationId "io.numbersprotocol.capturelite"
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
-        versionCode 340
-        versionName "0.51.0"
+        versionCode 341
+        versionName "0.51.1"
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     buildTypes {

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "capture-lite",
-  "version": "0.51.0",
+  "version": "0.51.1",
   "author": "numbersprotocol",
   "homepage": "https://numbersprotocol.io/",
   "scripts": {

package.json

@@ -142,9 +142,19 @@ export class ActionsPage {
         concatMap(orderId =>
           this.blockingActionService.run$(this.confirmOrder$(orderId))
         ),
-        tap(networkAppOrder =>
-          this.createOrderHistory$(networkAppOrder).subscribe()
-        ),
+        tap(networkAppOrder => {
+          /*
+            Workaround:
+            Create a order history record only if the total cost is > 0 to prevent race condition 
+            between app creating the order history record v.s. bubble workflow checking whether a 
+            record already exists and if not create a new one, especially for network actions that 
+            don't require any cost (and hence backend calls the webhook immediately). See 
+            https://dt42-numbers.slack.com/archives/C0323488MEJ/p1648006014291339
+          */
+          if (Number(networkAppOrder.total_cost) !== 0) {
+            this.createOrderHistory$(networkAppOrder).subscribe();
+          }
+        }),
         tap(() => {
           this.snackBar.open(
             this.translocoService.translate('message.sentSuccessfully')