fix(utilities): compilation error

Author: matkoch

source/Nuke.Build.Shared/CompletionUtility.cs

@@ -84,7 +84,7 @@ public static IEnumerable<string> GetRelevantItems(
         completionItems = new Dictionary<string, string[]>(completionItems.ToDictionary(x => x.Key, x => x.Value), StringComparer.OrdinalIgnoreCase).AsReadOnly();
         var suggestedItems = new List<string>();
 
-        var parts = words.Split(separator: ' ');
+        ICollection<string> parts = words.Split(separator: ' ');
         var currentWord = parts.Last() != string.Empty ? parts.Last() : null;
         var parameters = parts.Where(ArgumentParser.IsArgument).Select(ArgumentParser.GetArgumentMemberName).ToList();
         var lastParameter = parameters.LastOrDefault();

source/Nuke.Utilities/Text/String.Join.cs

@@ -125,9 +125,9 @@ public static string JoinCommaSpace(this IEnumerable<string> values)
     [Pure]
     public static string JoinCommaOr(this IEnumerable<string> values)
     {
-        var valuesList = values.ToArray();
-        return valuesList.Length >= 2
-            ? valuesList.Reverse().Skip(1).Reverse().JoinCommaSpace() + $"{(valuesList.Length > 2 ? "," : string.Empty)} or " + valuesList.Last()
+        ICollection<string> valuesList = values.ToList();
+        return valuesList.Count >= 2
+            ? valuesList.Reverse().Skip(1).Reverse().JoinCommaSpace() + $"{(valuesList.Count > 2 ? "," : string.Empty)} or " + valuesList.Last()
             : valuesList.JoinCommaSpace();
     }
 
@@ -137,9 +137,9 @@ public static string JoinCommaOr(this IEnumerable<string> values)
     [Pure]
     public static string JoinCommaAnd(this IEnumerable<string> values)
     {
-        var valuesList = values.ToArray();
-        return valuesList.Length >= 2
-            ? valuesList.Reverse().Skip(1).Reverse().JoinCommaSpace() + $"{(valuesList.Length > 2 ? "," : string.Empty)} and " + valuesList.Last()
+        ICollection<string> valuesList = values.ToList();
+        return valuesList.Count >= 2
+            ? valuesList.Reverse().Skip(1).Reverse().JoinCommaSpace() + $"{(valuesList.Count > 2 ? "," : string.Empty)} and " + valuesList.Last()
             : valuesList.JoinCommaSpace();
     }