Merge branch 'hotfix/9.0.2' into develop

Author: matkoch

.run/Generate-Tools.run.xml

@@ -12,7 +12,7 @@
     <option name="PROJECT_ARGUMENTS_TRACKING" value="1" />
     <option name="PROJECT_WORKING_DIRECTORY_TRACKING" value="1" />
     <option name="PROJECT_KIND" value="DotNetCore" />
-    <option name="PROJECT_TFM" value="net7.0" />
+    <option name="PROJECT_TFM" value="net8.0" />
     <method v="2">
       <option name="Build" />
     </method>

.run/Publish MSBuildTasks.run.xml

@@ -1,10 +1,10 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="Publish MSBuildTasks" type="RunNativeExe" factoryName="Native Executable">
     <option name="EXE_PATH" value="/usr/local/share/dotnet/dotnet" />
-    <option name="PROGRAM_PARAMETERS" value="publish --framework net9.0" />
+    <option name="PROGRAM_PARAMETERS" value="publish --framework net8.0" />
     <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/source/Nuke.MSBuildTasks" />
     <option name="PASS_PARENT_ENVS" value="1" />
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
     <method v="2" />
   </configuration>
-</component>
+</component>

CHANGELOG.md

@@ -6,6 +6,19 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [vNext]
 
+## [9.0.2] / 2024-12-03
+- Fixed MSBuild tasks to use `net8.0` target framework
+- Fixed error handling in `:update` command
+- Fixed resolving tool path from options
+- Fixed nullable options for `ToolTasks.Run`
+- Fixed nullable underlying dictionary for delegate properties
+- Fixed skipping null and whitespace arguments
+- Fixed tool requirements
+- Fixed NPM tool path resolution
+- Fixed logging errors as standard in `GitTasks` and `DockerTasks`
+- Fixed argument format in `DotNetTasks`
+- Fixed nullable `Plugins` dictionary in `ReSharperTasks` 
+
 ## [9.0.1] / 2024-11-21
 - Fixed `Options` serialization to JSON
 - Fixed `Options` for default members in interfaces
@@ -1183,7 +1196,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Added CLT tasks for Git
 - Fixed background color in console output
 
-[vNext]: https://github.com/nuke-build/nuke/compare/9.0.1...HEAD
+[vNext]: https://github.com/nuke-build/nuke/compare/9.0.2...HEAD
+[9.0.2]: https://github.com/nuke-build/nuke/compare/9.0.1...9.0.2
 [9.0.1]: https://github.com/nuke-build/nuke/compare/9.0.0...9.0.1
 [9.0.0]: https://github.com/nuke-build/nuke/compare/8.1.4...9.0.0
 [8.1.4]: https://github.com/nuke-build/nuke/compare/8.1.3...8.1.4

build/_build.csproj

@@ -16,7 +16,7 @@
   <!-- Test properties for MSBuild integration -->
   <PropertyGroup>
     <NukeTasksEnabled Condition="'$(NukeTasksEnabled)' == ''">False</NukeTasksEnabled>
-    <NukeTasksDirectory>$(MSBuildThisFileDirectory)\..\source\Nuke.MSBuildTasks\bin\Debug\net9.0\publish</NukeTasksDirectory>
+    <NukeTasksDirectory>$(MSBuildThisFileDirectory)\..\source\Nuke.MSBuildTasks\bin\Debug\net8.0\publish</NukeTasksDirectory>
 
 <!--    <PackAsTool>True</PackAsTool>-->
 <!--    <ToolCommandName>build</ToolCommandName>-->

source/Nuke.Build/Execution/TargetDefinition.cs

@@ -140,14 +140,14 @@ public ITargetDefinition Requires(Expression<Func<bool>> requirement, params Exp
     public ITargetDefinition Requires<T>()
         where T : IRequireTool
     {
-        ToolRequirements.Add(typeof(T).GetCustomAttribute<ToolRequirementAttributeBase>().NotNull().GetRequirement());
+        ToolRequirements.Add(typeof(T).GetCustomAttribute<ToolAttribute>().NotNull().GetRequirement());
         return this;
     }
 
     public ITargetDefinition Requires<T>(string version)
         where T : IRequireToolWithVersion
     {
-        ToolRequirements.Add(typeof(T).GetCustomAttribute<ToolRequirementAttributeBase>().NotNull().GetRequirement(version));
+        ToolRequirements.Add(typeof(T).GetCustomAttribute<ToolAttribute>().NotNull().GetRequirement(version));
         return this;
     }
 

source/Nuke.Build/RequiresAttribute.cs

@@ -22,6 +22,6 @@ public class RequiresAttribute<T> : RequiresAttribute
 
     public override ToolRequirement GetRequirement()
     {
-        return typeof(T).GetCustomAttribute<ToolRequirementAttributeBase>().NotNull().GetRequirement(Version);
+        return typeof(T).GetCustomAttribute<ToolAttribute>().NotNull().GetRequirement(Version);
     }
 }

source/Nuke.Common.Tests/SettingsTest.cs

@@ -117,8 +117,24 @@ public void TestDotNet()
         Assert(new DotNetRunSettings()
                 .AddApplicationArguments("arg1")
                 .AddApplicationArguments("arg2")
-                .SetProperty("foo", "bar"),
-            "run --property:foo=bar -- arg1 arg2");
+                .SetProperty("foo", "bar")
+                .SetInformationalVersion("version"),
+            "run --property:foo=bar --property:InformationalVersion=version -- arg1 arg2");
+
+        Assert(new DotNetPackSettings()
+                .SetAuthors("a", "b"),
+            "pack --property:Authors=a,b");
+    }
+
+    [Fact]
+    public void TestDotNet_Empty()
+    {
+        Assert(new DotNetBuildSettings()
+                .SetFramework(null)
+                .SetConfiguration("")
+                .SetProperty("foo1", null)
+                .SetProperty("foo2", ""),
+            "build");
     }
 
     [Fact]
@@ -157,9 +173,10 @@ public void TestKubernetes()
             "exec --container=container --cluster=cluster -- command arg1 arg2");
     }
 
-    private static void Assert<T>(T options, string arguments)
+    private static void Assert<T>(T options, string expected)
         where T : ToolOptions, new()
     {
-        options.GetArguments().JoinSpace().Should().Be(arguments);
+        var arguments = options.GetArguments().JoinSpace();
+        arguments.Should().Be(expected);
     }
 }

source/Nuke.Common/Attributes/NpmPackageAttribute.cs

@@ -25,7 +25,7 @@ public NpmPackageAttribute(string packageId, string packageExecutable = null)
 
     public override ToolRequirement GetRequirement(MemberInfo member)
     {
-        return NpmPackageRequirement.Create(_packageId, Version);
+        return new NpmPackageRequirement(_packageId, Version);
     }
 
     public override object GetValue(MemberInfo member, object instance)

source/Nuke.Common/Attributes/NuGetPackageAttribute.cs

@@ -55,7 +55,7 @@ public NuGetPackageAttribute(string packageId, string packageExecutable32, strin
 
     public override ToolRequirement GetRequirement(MemberInfo member)
     {
-        return NuGetPackageRequirement.Create(_packageId, Version);
+        return new NuGetPackageRequirement(_packageId, Version);
     }
 
     public override object GetValue(MemberInfo member, object instance)

source/Nuke.Common/Attributes/PathVariableAttribute.cs

@@ -41,7 +41,7 @@ public PathVariableAttribute(string pathExecutable = null)
     public override ToolRequirement GetRequirement(MemberInfo member)
     {
         var name = _pathExecutable ?? member.Name.ToLowerInvariant();
-        return PathToolRequirement.Create(name);
+        return new PathToolRequirement(name);
     }
 
     public override object GetValue(MemberInfo member, object instance)