Remove deprecated uppercase URL attribute alias from EventSource interface

Ahmad-S792 · Ahmad Saleem · commit 710c43c6b66e · 2022-12-08T01:53:32.000-08:00
Remove deprecated uppercase URL attribute alias from EventSource interface https://bugs.webkit.org/show_bug.cgi?id=248787 Reviewed by Ryosuke Niwa. This is to align Webkit with Blink / Chromium, Gecko / Firefox and Web-Specifications: https://html.spec.whatwg.org/multipage/server-sent-events.html#the-eventsource-interface Partial Merge - https://chromium.googlesource.com/chromium/blink/+/f0e6045bfaa96d3a3211e8074feb83d37913f9d3 The upper case "URL" attribute was only in draft specifications from 2009 but later dropped in 2011 specs, which were implemented by non-Webkit browsers. It was later dropped by Blink in 2015 as well. * Source/WebCore/page/EventSource.idl: Remove 'URL' attribute and also add link to web-spec * LayoutTests/http/tests/eventsource/eventsource-url-attribute.html: Rebaselined * LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/257553@main
diff --git a/LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt b/LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt
@@ -1,11 +1,10 @@
-Both .URL and .url should work (for compatibility reasons).
+Only .url should work, previously supported .URL should not.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS source.URL is "http://127.0.0.1:8000/eventsource/resources/event-stream.py"
 PASS source.url is "http://127.0.0.1:8000/eventsource/resources/event-stream.py"
-PASS source.URL === source.url is true
+PASS source.URL is undefined.
 PASS successfullyParsed is true
 
 TEST COMPLETE
diff --git a/LayoutTests/http/tests/eventsource/eventsource-url-attribute.html b/LayoutTests/http/tests/eventsource/eventsource-url-attribute.html
@@ -7,14 +7,13 @@
 <body>
 <script>
 
-description("Both .URL and .url should work (for compatibility reasons).");
+description("Only .url should work, previously supported .URL should not.");
 
 var url = "http://127.0.0.1:8000/eventsource/resources/event-stream.py";
 var source = new EventSource(url);
 
-shouldBeEqualToString("source.URL", url);
 shouldBeEqualToString("source.url", url);
-shouldBeTrue("source.URL === source.url");
+shouldBeUndefined("source.URL");
 
 </script>
 <script src="../../js-test-resources/js-test-post.js"></script>
diff --git a/Source/WebCore/page/EventSource.idl b/Source/WebCore/page/EventSource.idl
@@ -1,6 +1,6 @@
 /*
  * Copyright (C) 2009 Ericsson AB. All rights reserved.
- * Copyright (C) 2010, 2011 Apple Inc. All Rights Reserved.
+ * Copyright (C) 2010-2022 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -29,13 +29,14 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+// https://html.spec.whatwg.org/multipage/server-sent-events.html#the-eventsource-interface
+
 [
     Exposed=(Window,Worker),
     ActiveDOMObject,
 ] interface EventSource : EventTarget {
     [CallWith=CurrentScriptExecutionContext] constructor(USVString url, optional EventSourceInit eventSourceInitDict);
 
-    readonly attribute USVString URL; // Lowercased .url is the one in the spec, but leaving .URL for compatibility reasons.
     readonly attribute USVString url;
     readonly attribute boolean withCredentials;
 
