Remove Legacy/Breaking Create pages API method ⚰️

* Update the breaking unit tests

Author: KoditkarVedant

Src/Notion.Client/Api/Pages/IPagesClient.cs

@@ -5,8 +5,6 @@ namespace Notion.Client
 {
     public interface IPagesClient
     {
-        Task<Page> CreateAsync(NewPage page);
-
         /// <summary>
         /// Creates a new page in the specified database or as a child of an existing page.
         /// 

Src/Notion.Client/Api/Pages/PagesClient.cs

@@ -14,26 +14,6 @@ public PagesClient(IRestClient client)
             _client = client;
         }
 
-        public async Task<Page> CreateAsync(NewPage page)
-        {
-            if (page == null)
-            {
-                throw new ArgumentNullException(nameof(page));
-            }
-
-            if (page.Parent == null)
-            {
-                throw new ArgumentNullException(nameof(page.Parent), "Parent is required!");
-            }
-
-            if (page.Properties == null)
-            {
-                throw new ArgumentNullException(nameof(page.Properties), "Properties are required!");
-            }
-
-            return await _client.PostAsync<Page>(PagesApiUrls.Create(), page);
-        }
-
         /// <summary>
         /// Creates a new page in the specified database or as a child of an existing page.
         /// 

Src/Notion.Client/Models/Page/NewPage.cs

@@ -56,12 +56,10 @@ public async Task CreateAsync()
                     .WithBody(jsonData)
             );
 
-            var newPage = new NewPage(new PageParent
+            var pagesCreateParameters = PagesCreateParametersBuilder.Create(new DatabaseParentInput
             {
-                PageId = "3c357473-a281-49a4-88c0-10d2b245a589"
-            });
-
-            newPage.AddProperty("Name", new TitlePropertyValue()
+                DatabaseId = "3c357473-a281-49a4-88c0-10d2b245a589"
+            }).AddProperty("Name", new TitlePropertyValue()
             {
                 Title = new List<RichTextBase>()
                 {
@@ -73,17 +71,17 @@ public async Task CreateAsync()
                         }
                     }
                 }
-            });
+            }).Build();
 
-            var page = await _client.CreateAsync(newPage);
+            var page = await _client.CreateAsync(pagesCreateParameters);
 
             page.Id.Should().NotBeNullOrEmpty();
             page.Url.Should().NotBeNullOrEmpty();
             page.Properties.Should().HaveCount(1);
             page.Properties.First().Key.Should().Be("Name");
             page.IsArchived.Should().BeFalse();
             page.Parent.Should().NotBeNull();
-            ((PageParent)page.Parent).PageId.Should().Be("3c357473-a281-49a4-88c0-10d2b245a589");
+            ((DatabaseParent)page.Parent).DatabaseId.Should().Be("3c357473-a281-49a4-88c0-10d2b245a589");
         }
 
         [Fact]
@@ -201,32 +199,35 @@ public async Task ArchivePageAsync()
         [Fact]
         public async Task CreateAsync_Throws_ArgumentNullException_When_Parameter_Is_Null()
         {
-            Func<Task> act = async () => await _client.CreateAsync(page: null);
+            Func<Task> act = async () => await _client.CreateAsync(null);
 
-            (await act.Should().ThrowAsync<ArgumentNullException>()).And.ParamName.Should().Be("page");
+            (await act.Should().ThrowAsync<ArgumentNullException>()).And.ParamName.Should().Be("pagesCreateParameters");
         }
 
         [Fact]
         public async Task CreateAsync_Throws_ArgumentNullException_When_Parent_Is_Missing()
         {
-            var newPage = new NewPage(null);
+            var pagesCreateParameters = PagesCreateParametersBuilder.Create(null).Build();
 
-            Func<Task> act = async () => await _client.CreateAsync(newPage);
+            Func<Task> act = async () => await _client.CreateAsync(pagesCreateParameters);
 
             (await act.Should().ThrowAsync<ArgumentNullException>()).And.ParamName.Should().Be("Parent");
         }
 
         [Fact]
         public async Task CreateAsync_Throws_ArgumentNullException_When_Properties_Is_Missing()
         {
-            var newPage = new NewPage(new PageParent()
+            var pagesCreateParameters = new PagesCreateParameters
             {
-                PageId = "3c357473-a281-49a4-88c0-10d2b245a589"
-            });
+                Parent = new ParentPageInput()
+                {
+                    PageId = "3c357473-a281-49a4-88c0-10d2b245a589",
 
-            newPage.Properties = null;
+                },
+                Properties = null
+            };
 
-            Func<Task> act = async () => await _client.CreateAsync(newPage);
+            Func<Task> act = async () => await _client.CreateAsync(pagesCreateParameters);
 
             (await act.Should().ThrowAsync<ArgumentNullException>()).And.ParamName.Should().Be("Properties");
         }

Test/Notion.UnitTests/PagesClientTests.cs

@@ -31,7 +31,7 @@
     }
   },
   "parent": {
-    "page_id": "3c357473-a281-49a4-88c0-10d2b245a589",
-    "type": "page_id"
+    "database_id": "3c357473-a281-49a4-88c0-10d2b245a589",
+    "type": "database_id"
   }
-}
+}