Refactor rest client ♻️

- Throws NotionApiException if there is any error while calling API
- Allow options to configure header
- Use the SendAsync and HttpRequestMessage to form the request

Author: KoditkarVedant

Src/Notion.Client/Extensions/HttpResponseMessageExtensions.cs

@@ -0,0 +1,36 @@
+using System.IO;
+using System.Net.Http;
+using System.Threading.Tasks;
+using Newtonsoft.Json;
+
+namespace Notion.Client.Extensions
+{
+    internal static class HttpResponseMessageExtensions
+    {
+        internal static async Task<T> ParseStreamAsync<T>(this HttpResponseMessage response, JsonSerializerSettings serializerSettings = null)
+        {
+            using (Stream stream = await response.Content.ReadAsStreamAsync())
+            {
+                using (StreamReader streamReader = new StreamReader(stream))
+                {
+                    using (JsonReader jsonReader = new JsonTextReader(streamReader))
+                    {
+
+                        JsonSerializer serializer = null;
+
+                        if (serializerSettings == null)
+                        {
+                            serializer = JsonSerializer.CreateDefault();
+                        }
+                        else
+                        {
+                            serializer = JsonSerializer.Create(serializerSettings);
+                        }
+
+                        return serializer.Deserialize<T>(jsonReader);
+                    }
+                }
+            }
+        }
+    }
+}

Src/Notion.Client/NotionApiException.cs

@@ -0,0 +1,17 @@
+using System;
+using System.Net;
+
+namespace Notion.Client
+{
+    class NotionApiException : Exception
+    {
+        public NotionApiException(HttpStatusCode statusCode, string message) : this(statusCode, message, null)
+        {
+        }
+
+        public NotionApiException(HttpStatusCode statusCode, string message, Exception innerException) : base(message, innerException)
+        {
+            Data.Add("StatusCode", statusCode);
+        }
+    }
+}

Src/Notion.Client/RestClient.cs

@@ -3,16 +3,30 @@
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Text;
+using System.Threading;
 using System.Threading.Tasks;
 using Newtonsoft.Json;
+using Notion.Client.Extensions;
 using Notion.Client.http;
 
 namespace Notion.Client
 {
     public interface IRestClient
     {
-        Task<T> GetAsync<T>(string uri, Dictionary<string, string> queryParams = null);
-        Task<T> PostAsync<T>(string uri, object body);
+        Task<T> GetAsync<T>(
+            string uri,
+            IDictionary<string, string> queryParams = null,
+            IDictionary<string, string> headers = null,
+            JsonSerializerSettings serializerSettings = null,
+            CancellationToken cancellationToken = default);
+
+        Task<T> PostAsync<T>(
+            string uri,
+            object body,
+            IDictionary<string, string> queryParams = null,
+            IDictionary<string, string> headers = null,
+            JsonSerializerSettings serializerSettings = null,
+            CancellationToken cancellationToken = default);
     }
 
     public class RestClient : IRestClient
@@ -21,7 +35,7 @@ public class RestClient : IRestClient
         private readonly ClientOptions _options;
         private readonly List<JsonConverter> jsonConverters = new List<JsonConverter>();
 
-        private readonly JsonSerializerSettings serializerSettings = new JsonSerializerSettings
+        private readonly JsonSerializerSettings defaultSerializerSettings = new JsonSerializerSettings
         {
             NullValueHandling = NullValueHandling.Ignore
         };
@@ -41,32 +55,89 @@ private static ClientOptions MergeOptions(ClientOptions options)
             };
         }
 
-        public async Task<T> GetAsync<T>(string uri, Dictionary<string, string> queryParams = null)
+        public async Task<T> GetAsync<T>(
+            string uri,
+            IDictionary<string, string> queryParams = null,
+            IDictionary<string, string> headers = null,
+            JsonSerializerSettings serializerSettings = null,
+            CancellationToken cancellationToken = default)
         {
             EnsureHttpClient();
 
-            uri = queryParams == null ? uri : QueryHelpers.AddQueryString(uri, queryParams);
+            string requestUri = queryParams == null ? uri : QueryHelpers.AddQueryString(uri, queryParams);
 
-            using (var stream = await _httpClient.GetStreamAsync(uri))
+            var response = await SendAsync(requestUri, HttpMethod.Get, headers, cancellationToken: cancellationToken);
+
+            if (response.IsSuccessStatusCode)
             {
-                return SerializerHelper.Deserialize<T>(stream, jsonConverters);
+                return await response.ParseStreamAsync<T>(serializerSettings);
             }
+
+            var message = !string.IsNullOrWhiteSpace(response.ReasonPhrase)
+                    ? response.ReasonPhrase
+                    : await response.Content.ReadAsStringAsync();
+
+            throw new NotionApiException(response.StatusCode, message);
         }
 
-        public async Task<T> PostAsync<T>(string uri, object body)
+        private async Task<HttpResponseMessage> SendAsync(
+            string requestUri,
+            HttpMethod httpMethod,
+            IDictionary<string, string> headers = null,
+            Action<HttpRequestMessage> attachContent = null,
+            CancellationToken cancellationToken = default)
         {
-            EnsureHttpClient();
+            HttpRequestMessage httpRequest = new HttpRequestMessage(httpMethod, requestUri);
+            httpRequest.Headers.Authorization = new AuthenticationHeaderValue("Bearer", _options.AuthToken);
+            httpRequest.Headers.Add("Notion-Version", _options.NotionVersion);
+
+            if (headers != null)
+            {
+                AddHeaders(httpRequest, headers);
+            }
+
+            attachContent?.Invoke(httpRequest);
+
+            return await _httpClient.SendAsync(httpRequest, cancellationToken);
+        }
+
+        private static void AddHeaders(HttpRequestMessage request, IDictionary<string, string> headers)
+        {
+            foreach (var header in headers)
+            {
+                request.Headers.Add(header.Key, header.Value);
+            }
+        }
 
-            var content = new StringContent(JsonConvert.SerializeObject(body, serializerSettings), Encoding.UTF8, "application/json");
+        public async Task<T> PostAsync<T>(
+            string uri,
+            object body,
+            IDictionary<string, string> queryParams = null,
+            IDictionary<string, string> headers = null,
+            JsonSerializerSettings serializerSettings = null,
+            CancellationToken cancellationToken = default)
+        {
+            EnsureHttpClient();
 
-            using (var response = await _httpClient.PostAsync(uri, content))
+            void AttachContent(HttpRequestMessage httpRequest)
             {
-                response.EnsureSuccessStatusCode();
+                httpRequest.Content = new StringContent(JsonConvert.SerializeObject(body, defaultSerializerSettings), Encoding.UTF8, "application/json");
+            }
+
+            string requestUri = queryParams == null ? uri : QueryHelpers.AddQueryString(uri, queryParams);
 
-                var stream = await response.Content.ReadAsStreamAsync();
+            var response = await SendAsync(requestUri, HttpMethod.Post, headers, AttachContent, cancellationToken: cancellationToken);
 
-                return SerializerHelper.Deserialize<T>(stream, jsonConverters);
+            if (response.IsSuccessStatusCode)
+            {
+                return await response.ParseStreamAsync<T>(serializerSettings);
             }
+
+            var message = !string.IsNullOrWhiteSpace(response.ReasonPhrase)
+                    ? response.ReasonPhrase
+                    : await response.Content.ReadAsStringAsync();
+
+            throw new NotionApiException(response.StatusCode, message);
         }
 
         private HttpClient EnsureHttpClient()
@@ -75,8 +146,6 @@ private HttpClient EnsureHttpClient()
             {
                 _httpClient = new HttpClient();
                 _httpClient.BaseAddress = new Uri(_options.BaseUrl);
-                _httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", _options.AuthToken);
-                _httpClient.DefaultRequestHeaders.Add("Notion-Version", _options.NotionVersion);
             }
 
             return _httpClient;